Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Home Office button component #515

Closed
tomyems opened this issue May 12, 2023 · 2 comments · Fixed by #573
Closed

Create Home Office button component #515

tomyems opened this issue May 12, 2023 · 2 comments · Fixed by #573

Comments

@tomyems
Copy link
Contributor

tomyems commented May 12, 2023

Using the NotGovUK button component (with GOV.UK styling) and signposting to the GOV.UK design system guidance on the use of buttons, create a Home Office button component, with the only difference being styling of the secondary button equivalent to that described in the discussion: #372 (comment).

@tomyems
Copy link
Contributor Author

tomyems commented May 12, 2023

There's an attempt on branch https://github.com/UKHomeOffice/design-system/tree/515-new-button-component to:

  • create a HomeOfficeButton component that extends the NotGovUK component replacing 'govuk-button' with 'hods-button'
  • update the status message component to use styling like the secondary button component

This branch has a number of issues:

  • no tests
  • does all the GOV.UK design system button functionality work, such as disabled, warning and so on (and what's the best way to future proof against further improvements)?
  • the status message uses links styled as buttons, is this best, or should it use the button component

Also, do we need a new component name, like HomeOfficeButton, as this conflicts with the naming convention for the other components?

There are more GOV.UK components that we might 'just' need to apply Home Office styling to, such as tabs and tags, so we need a consistent way of developing these.

@tomyems
Copy link
Contributor Author

tomyems commented May 12, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant