Page: Add custom styling to secondary buttons #540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The grey background causes accessibility issues when used with secondary buttons. This oversides some of the styling to provide a black border for the button.
|
@tomyems: Knocked this up to see if I could fix the small issues around:
It also demonstrates the idea of demonstrating the styling within the We don't have to use it. If you like you could incorporate some of the code into your branch. Take a look and see what you think. |
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grey background causes accessibility issues when used with secondary
buttons. This overrides some of the styling to provide a black border
for the button.
This is an alternative implementation to #518.
closes: #515