Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sex gender pattern #517

Merged
merged 19 commits into from
Aug 23, 2023
Merged

Sex gender pattern #517

merged 19 commits into from
Aug 23, 2023

Conversation

Sallytolson
Copy link
Contributor

No description provided.

Draft version of the 'Ask users for their sex or gender' pattern.
@Sallytolson Sallytolson requested a review from tomyems May 18, 2023 16:02
@github-actions github-actions bot temporarily deployed to commit May 18, 2023 16:04 Inactive
@github-actions github-actions bot temporarily deployed to commit May 19, 2023 08:14 Inactive
Copy link
Collaborator

@daniel-ac-martin daniel-ac-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine from a technical perspective.

I wonder if it's helpful to be explicit about when 'other' is a valid option or not. (Perhaps with a second example.) The text covers this though.

I also wonder if it's worth pointing out that due to low cardinality, it's often not very helpful to ask for sex as it doesn't narrow down a set of search results as much as other information would, for example.

@daniel-ac-martin
Copy link
Collaborator

Oh just noticed...

Are we linking to the correct GitHub discussion at the bottom of the page?

Copy link
Contributor

@tomyems tomyems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should include a 'Writing for this pattern' section for this page, to perhaps help designers:

  • understand the purpose behind the 'why we ask this question' text, and so help them write it
  • ask this question when the type of travel document is known, such as it has to be a passport

We should link back to the sex and gender discussion (#347) in the 'help us improve this pattern'.

The content and pattern looks good. Couple of quick questions, how important is 'their' in the title, does it work without it? In the headings I wondered what you thought about 'ask' rather than 'asking'?

I've got a few suggestions for improving the menu on the left-hand side too, which we can try at the same time. :)

@tomyems tomyems marked this pull request as draft May 24, 2023 11:15
@Sarraounia
Copy link
Contributor

I wonder if we should include a 'Writing for this pattern' section for this page, to perhaps help designers:

  • understand the purpose behind the 'why we ask this question' text, and so help them write it
  • ask this question when the type of travel document is known, such as it has to be a passport

We should link back to the sex and gender discussion (#347) in the 'help us improve this pattern'.

The content and pattern looks good. Couple of quick questions, how important is 'their' in the title, does it work without it? In the headings I wondered what you thought about 'ask' rather than 'asking'?

I've got a few suggestions for improving the menu on the left-hand side too, which we can try at the same time. :)

Thanks so much for your comments @tomyems. Have made some immediate changes based on your suggestions, which @Sallytolson will update in the prototype.

I've written some content for a new 'Writing for this pattern' section in answer to your first bullet point about the purpose behind the 'why we ask this question' text. However, I'm not sure what you meant by: 'ask this question when the type of travel document is known, such as it has to be a passport.' Do you have suggestions for what the content would be?

Agreed, I've changed it to 'ask' rather than 'asking.' Not sure about removing 'their' from the title. I think it could be misconstrued or read in an odd way. I'm not sure it works without, but happy to discuss.

Looking forward to your hearing your suggestions re. the left-hand menu.

@tomyems
Copy link
Contributor

tomyems commented May 26, 2023

localhost_8080_patterns_ask-sex-or-gender

I wondered about something like this, to closer align with the GOV.UK design system patterns?

Ah apologies, the other question wasn't very clear ... if by the time you're asking for sex, you know that they have a passport (because you've previously asked what kind of travel document do they have, or from context), would you suggest either:

  • asking 'What is your sex on your passport?' and removing the hint text
  • simplifying the hint text to 'This is the sex that is on your passport'

Happy to ignore this, or add it to the further research if we're not sure yet :)

@github-actions github-actions bot temporarily deployed to commit May 26, 2023 08:49 Inactive
@github-actions github-actions bot temporarily deployed to commit July 10, 2023 09:39 Inactive
@github-actions github-actions bot temporarily deployed to commit July 14, 2023 14:29 Inactive
@github-actions github-actions bot temporarily deployed to commit July 14, 2023 15:03 Inactive
@tomyems
Copy link
Contributor

tomyems commented Jul 14, 2023

@github-actions github-actions bot temporarily deployed to commit July 19, 2023 12:21 Inactive
@github-actions github-actions bot temporarily deployed to commit July 19, 2023 12:31 Inactive
@tomyems
Copy link
Contributor

tomyems commented Jul 19, 2023

@github-actions github-actions bot temporarily deployed to commit July 20, 2023 14:45 Inactive
@tomyems
Copy link
Contributor

tomyems commented Jul 20, 2023

With services described rather than named: https://64b94899fbb1810f7256c143--hods.netlify.app/patterns/ask-sex-or-gender

@github-actions github-actions bot temporarily deployed to commit July 31, 2023 13:26 Inactive
@github-actions github-actions bot temporarily deployed to commit August 1, 2023 08:30 Inactive
@github-actions github-actions bot temporarily deployed to commit August 22, 2023 10:23 Inactive
@github-actions github-actions bot temporarily deployed to commit August 23, 2023 07:33 Inactive
@daniel-ac-martin daniel-ac-martin marked this pull request as ready for review August 23, 2023 09:46
@daniel-ac-martin
Copy link
Collaborator

Note: Please squash these commits.

@daniel-ac-martin daniel-ac-martin merged commit d654812 into master Aug 23, 2023
14 checks passed
@daniel-ac-martin daniel-ac-martin deleted the sex-gender-pattern branch August 23, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants