Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pushed change which hadn't been applied before. To make links strong … #589

Closed
wants to merge 1 commit into from
Closed

pushed change which hadn't been applied before. To make links strong … #589

wants to merge 1 commit into from

Conversation

benjest85
Copy link
Contributor

…for alert

daniel-ac-martin
daniel-ac-martin reviewed Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@daniel-ac-martin daniel-ac-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine from a code perspective.

But should we use strong if we only want bold for visual reasons?

And if we are saying that all links should be bold within <Alert> then shouldn't we just make that they case without the need for extra, manual work?

@benjest85 benjest85 closed this Jul 11, 2024
@daniel-ac-martin daniel-ac-martin mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-ac-martin daniel-ac-martin daniel-ac-martin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjest85 @daniel-ac-martin