Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice and tone: Link directly to discussion #602

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

daniel-ac-martin
Copy link
Collaborator

Updates the GitHub discussion link to go directly to the relevant discussion.

Updates the GitHub discussion link to go directly to the relevant discussion.
@daniel-ac-martin
Copy link
Collaborator Author

@Sarah-Lombardi: Do we want this? Or is it better to just link to the main discussions page?

@github-actions github-actions bot temporarily deployed to commit September 4, 2024 16:56 Inactive
@Sarah-Lombardi
Copy link
Contributor

@Sarah-Lombardi: Do we want this? Or is it better to just link to the main discussions page?

You’re right. It should link to the discussion itself. Good spot.

@daniel-ac-martin
Copy link
Collaborator Author

@Sarah-Lombardi: Do we want this? Or is it better to just link to the main discussions page?

You’re right. It should link to the discussion itself. Good spot.

Okay. Do you want to approve this change then? Thinks to think about:

  • Have I linked to the right discussion?
  • Have you taken a look at the preview? (Click 'view deployment' of the 'Details' link next to 'Netlify' in the list of checks at the bottom.)

It's best practice for someone else to review these. ;-)

@daniel-ac-martin
Copy link
Collaborator Author

@MylesMudaHO: Bit of a silly one (as it's so small), but do you want to review this from a technical perspective?

Copy link
Contributor

@MylesMudaHO MylesMudaHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it's a simple link change and it correctly redirects to the discussion page in the current deployment, it looks good to me!

@daniel-ac-martin daniel-ac-martin merged commit 5a49385 into master Sep 11, 2024
17 checks passed
@daniel-ac-martin daniel-ac-martin deleted the voice-and-tone-discussion-link branch September 11, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants