Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drtii 1683 api update for es #1951

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Drtii 1683 api update for es #1951

merged 3 commits into from
Nov 13, 2024

Conversation

richbirch
Copy link
Collaborator

Add fields:

  • origin port name
  • estimated landing time
  • actual chocks time

Use standardised status description

Copy link
Contributor

@ngu04 ngu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by restricting superadmin role , is api only for internal use at moment ?

@@ -63,7 +63,7 @@ class FlightsApiController @Inject()(cc: ControllerComponents, ctrl: DrtSystemIn
}

def populateFlights(start: String, end: String): Action[AnyContent] =
authByRole(ApiQueueAccess) {
authByRole(SuperAdmin) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this temporary or you meant to keep SuperAdmin ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an admin endpoint to populate data so it needs to be SuperAdmin

@richbirch richbirch merged commit 832f5c8 into master Nov 13, 2024
3 checks passed
@richbirch richbirch deleted the DRTII-1683-API-update-for-ES branch November 13, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants