Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #209 - support path prefix in related links #211

Merged
merged 6 commits into from
Aug 4, 2023

Conversation

jeff-horton-ho-sas
Copy link
Contributor

@jeff-horton-ho-sas jeff-horton-ho-sas commented Jul 31, 2023

Replaces or compliments #210 - adds mapping for related links frontmatter to include pathPrefix so that absolute links work.

Updates Cypress tests to support a path prefix so that this can be tested in the GitHub action test run.

Code change

I can confirm:

Accessibility considerations

  • This change might impact accessibility, automated aXe tests cover the impact

- Run CI tests using a path prefix
- Add test for related links
@jeff-horton-ho-sas jeff-horton-ho-sas linked an issue Jul 31, 2023 that may be closed by this pull request
Copy link
Contributor

@edhamiltonHO edhamiltonHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UKHomeOffice UKHomeOffice deleted a comment from kamioftea Aug 4, 2023
@jeff-horton-ho-sas jeff-horton-ho-sas merged commit 22f3832 into main Aug 4, 2023
@jeff-horton-ho-sas jeff-horton-ho-sas deleted the 209-use-path-prefix-for-related-links branch August 4, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Related link in standards page is not working
3 participants