fix: event withdrawn amounts #7
Conversation
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
UMA-2040 HoneyPotEmptied and PotReset not showing correct amounts
https://github.com/UMAprotocol/oev-demo/blob/master/src/HoneyPot.sol#L61 _emptyPotForUser is updating the stored balance before the events are emitted making the events to have 0 amounts. |
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
src/HoneyPot.sol
Outdated
| @@ -53,17 +53,17 @@ contract HoneyPot is Ownable { | |||
| (, int256 currentPrice,,,) = oracle.latestRoundData(); | |||
| require(currentPrice >= 0, "Invalid price from oracle"); | |||
|
|
|||
| HoneyPotDetails storage userPot = honeyPots[honeyPotCreator]; | |||
| HoneyPotDetails memory userPot = honeyPots[honeyPotCreator]; | |||
There was a problem hiding this comment.
Storage wasn't needed here.
There was a problem hiding this comment.
tiny nit: why change this?
In general, I think using storage references is usually (there are some exceptions) preferable (gas-wise) to copying the entire struct to memory because you may not actually need to SLOAD every element of the struct and you may end up using less memory overall by avoiding the copy. Does that make sense?
This is just a demo contract, so it's not super important, just wanted to make a note of it!
src/HoneyPot.sol
Outdated
| @@ -53,17 +53,17 @@ contract HoneyPot is Ownable { | |||
| (, int256 currentPrice,,,) = oracle.latestRoundData(); | |||
| require(currentPrice >= 0, "Invalid price from oracle"); | |||
|
|
|||
| HoneyPotDetails storage userPot = honeyPots[honeyPotCreator]; | |||
| HoneyPotDetails memory userPot = honeyPots[honeyPotCreator]; | |||
There was a problem hiding this comment.
tiny nit: why change this?
In general, I think using storage references is usually (there are some exceptions) preferable (gas-wise) to copying the entire struct to memory because you may not actually need to SLOAD every element of the struct and you may end up using less memory overall by avoiding the copy. Does that make sense?
This is just a demo contract, so it's not super important, just wanted to make a note of it!
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
md0x
deleted the
pablo/uma-2040-honeypotemptied-and-potreset-not-showing-correct-amounts
branch
Changes proposed in this PR: