improve: add ProposalExecuted event #4374
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Shutt pemulis@users.noreply.github.com
Motivation
We want a
ProposalExecuted
event tied to the original proposal time to make it easier for the Snapshot interface to determine whether a specific proposal was executed, and differentiate between duplicate transaction bundles that were created at different times.Summary
Adds a
ProposalExecuted
event that includes the proposal hash and the proposal time, which triggers on completion of theexecuteProposal
function.Details
For the V2 version of the contract, we should consider adding
proposalTime
to other events likeTransactionExecuted
andProposalDeleted
. To keep this PR limited, I did not alter those events.Testing
Check a box to describe how you tested these changes and list the steps for reviewers to test.
Issue(s)
Fixes #XXXX