fix(core): forge event tests

[Reinis-FRP]

Motivation

This update in foundry requires that expected events are emitted immediately in the next transaction. Without the fix protocol CI is blocking all PRs to be merged.

Summary

Fixes the issue by reorganizing foundry test logic so that there are no other transactions in between vm.expectEmit and the transaction that should trigger expected events.

Details

We were using _disputeAndGetOracleRequest subroutine after vm.expectEmit that mints and approves dispute bond. We move this funding logic before the vm.expectEmit to fix the issue.

Testing

Check a box to describe how you tested these changes and list the steps for reviewers to test.

• Ran end-to-end test, running the code as in production
• New unit tests created
• Existing tests adequate, no new tests required
• All existing tests pass
• Untested

Issue(s)

Fixes #XXXX

[md0x]

Nice.

[mrice32]

LGTM! Nice find!