feat: fetch implementation abi in transaction builder for proxy contracts #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gsteenkamp89
changed the title
daywiss
approved these changes
Feb 13, 2024
gsteenkamp89
merged commit 332182f
into
gerhard/uma-2153-ui-render-the-tenderly-simulation-button-in-the-tx-builder
4 checks passed
gsteenkamp89
deleted the
gerhard/uma-2372-fetch-implementation-abi-if-proxy
branch
gsteenkamp89
added a commit
that referenced
this pull request
Feb 13, 2024
daywiss
pushed a commit
that referenced
this pull request
Feb 19, 2024
gsteenkamp89
added a commit
that referenced
this pull request
Feb 21, 2024
daywiss
added a commit
that referenced
this pull request
Feb 22, 2024
* create base component logic * update styling * validate payload, handle request and update styles * better mobile styles * use separate reset button * feat: show warning if gas exceeds 500_000, refactor state (#121) * feat: add simulation in proposal view (#122) * feat: fetch implementation abi in transaction builder for proxy contracts (#124) * use isValid flag to check transactions in simulation * better feedback for EOA in "to" field & ABI with no write functions * clean up * reset parameters if ABI changes * revert extra green & red variables * fix typo * use better icon convention --------- Co-authored-by: Gerhard Steenkamp <gerhard@umaproject.org> Co-authored-by: Gerhard Steenkamp <51655063+gsteenkamp89@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation
DAOs might want to call functions on either the proxy contract OR the implementation contract for a given proposal.
atm users have 2 options:
changeAdmin()orupgrade()etc.We want to extend the fetching logic for proxy contracts, allowing for 3 possible options:
The UX here has not been decided on, but for an initial draft I've gone the same route as etherscan, a familiar pattern for us to test with, giving the user a dropdown so they can choose between