Move file downloads into the files table #1831
Conversation
… translations aren't in scope in the tests.
…ile's info into the restriction check instead of using the work's info.
lfarrell
force-pushed
the
login-modal
branch
from
ea07350
to
19d796f
Compare
|
|
||
| showImageDownload(brief_object) { | ||
| return this.hasPermission(brief_object, 'viewReducedResImages') && | ||
| brief_object.format.includes('Image') && this.getOriginalFile(brief_object) !== undefined |
There was a problem hiding this comment.
this should also take into account if there is a jp2
| @@ -0,0 +1,286 @@ | |||
| <template> | |||
| <div v-if="!isLoggedIn && restrictedFiles(recordData) && hasGroupRole(recordData, 'canViewOriginals', 'authenticated')" class="actionlink download"> | |||
| <a @click.prevent="modal_open = true" class="download login-modal-link button action" href="#">Contact Wilson/Log in to access</a> | |||
There was a problem hiding this comment.
Seems like we should use a t entry for the text here
|
|
||
| showNonImageDownload(brief_object) { | ||
| return this.hasPermission(brief_object, 'viewOriginal') && | ||
| !brief_object.format.includes('Image') && this.getOriginalFile(brief_object) !== undefined; |
There was a problem hiding this comment.
We should take into account whether the record has a jp2 or not, since that is what is actually required for the image download options. That could potentially take the place of the format check (seems like we still need there to be an original file too for nonImage downloads)
| @@ -1,20 +1,17 @@ | |||
| <template> | |||
There was a problem hiding this comment.
it seems like this file isn't really "restrictedContent" anymore, its more like top level actions for the current record. Maybe we should rename it? I was a bit confused at first why the file still exists since downloadOptions was doing the rendering of the "contact wilson/login" button
| expect(wrapper.find('.dropdown-menu').exists()).toBe(false); | ||
| }); | ||
|
|
||
| it('a login button when user is not logged in, but authenticated users canViewOriginals and viewReducedResImages but image is smaller than min size', async () => { |
There was a problem hiding this comment.
| it('a login button when user is not logged in, but authenticated users canViewOriginals and viewReducedResImages but image is smaller than min size', async () => { | |
| it('shows a login button when user is not logged in, but authenticated users canViewOriginals and viewReducedResImages but image is smaller than min size', async () => { |
|
Should also fix https://unclibrary.atlassian.net/browse/BXC-4778 now. |
https://unclibrary.atlassian.net/browse/BXC-4756