Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HYC 1678 - Dimensions ingest email report generation #1100

Merged
merged 30 commits into from
May 30, 2024
Merged

HYC 1678 - Dimensions ingest email report generation #1100

merged 30 commits into from
May 30, 2024

Conversation

davidcam-src
Copy link
Contributor

@davidcam-src davidcam-src commented May 25, 2024 •
edited
Loading

https://unclibrary.atlassian.net/browse/HYC-1678

  • Small modifications to ingest service to include article ids for reporting purposes
  • DimensionsReportingService, DimensionsReportMailer and html template for email report generation
  • Tests for aforementioned classes and preview class for rendered html template

@davidcam-src
tweaking ingest service, introducing reporting service
1bee634
@davidcam-src
syntax, including test suite
8248933
@davidcam-src
small changes to reporting service and ingest
96ebbbe
@davidcam-src
tests for report generation helper function
d78b5c8
@davidcam-src
slight phrasing change, updating test
e1b8e2a
@davidcam-src
changes to ingest and reporting service to include cdr urls in email …
31a7cec 
…reports
@davidcam-src
configuration for action mailer, slight refactor to report generation
668b778
@davidcam-src
syntax
a4857f1
@davidcam-src
test refactoring
3a7a21e
@davidcam-src
rubocop, mailer preview and tests
d6b76fa
@davidcam-src
removing comment
862ed0f
@davidcam-src
rubocop, renaming some stuff, updating preview class
5db8bab
@davidcam-src
adding comment
0550464
@davidcam-src
code climate
467f8b4
@davidcam-src
rubocop
b1a3369
@davidcam-src
addressing failing test
86d40d2
@davidcam-src
logs for debugging pr
4d73750
@davidcam-src
another log statement
901b598
@davidcam-src
modified build step to save time
58dc740
@davidcam-src
modified logging for debugging
f63ff6e
@davidcam-src
temporarily adding env variable to build yaml, logging
38cc7a2
@davidcam-src
rubocop
4554b58
@davidcam-src
moving ingested publications to after virus checker stubbing
c71489a
@davidcam-src
removing configuration stuff and debug logs, moving dimensions ingest…
cb0d54b 
… in mailer test, adding host to url interpolation
@davidcam-src
simulating missing pdfs in email report preview and reporting service…
958d32d 
… tests
@davidcam-src
updating build yml
a4e975f
@davidcam-src
updating column title
f0a7f93
@davidcam-src
rolling back debugging related change to build yml
2973f65
@bbpennel bbpennel merged commit 5a832e9 into main May 30, 2024
4 checks passed
@bbpennel bbpennel deleted the hyc-1678-dimensions-email branch May 30, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbpennel bbpennel bbpennel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidcam-src @bbpennel