Fix handling of deprecated CMake cache variables #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR... I'll take a look at this and see if I can get it merged in the next few days... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I'm a new user of this library. The docs led me to use the deprecated versions of the CMake cache variables.
Previously, the
set( ... CACHE ... )command was not used correctly. Replacing an existing cache variable would also require using the "FORCE" keyword.In addition to fixing
set(), I also changed the relative order of option(...) and set(...), because keeping them in the previous order and usingset(... CACHE ... FORCE)would have required duplication of the description strings.This fix produces what I believe to have been the intended behavior.
Thanks!