Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing APEX dependencies for HPX modules #99

Merged
merged 1 commit into from
Apr 22, 2019

Conversation

sithhell
Copy link
Contributor

@msimberg
Copy link
Contributor

Note: I'm planning to change the target name to hpx_pp for consistency (we have hpx_init, hpx_wrap, hpx_<component_name>, etc.) still before the release. You might want to wait until that's in master.

@msimberg
Copy link
Contributor

If we go ahead and merge STEllAR-GROUP/hpx#3811 we'll just need to change the name and remove the global include directory. @sithhell I opened a PR against this branch to change it.

@khuck going forward it's not very sustainable that you have to check before a release that everything is ok. We should really have CI for HPX with APEX enabled to catch these situations earlier. Last time I checked some tests in HPX timed out with APEX enabled but I never had time to look into them. Would you have time to help us get those sorted out sometime after the next release?

@khuck
Copy link
Collaborator

khuck commented Apr 22, 2019

@msimberg absolutely - if you could set up an HPX+APEX CI that would be great. I am curious about any tests timing out, but it's been a long time since APEX was integrated into HPX so whatever issues there might have been are likely gone now.

@khuck khuck merged commit 4b4560d into UO-OACISS:develop Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HPX won't compile with -DHPX_WITH_APEX=TRUE
3 participants