-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module-info.java to the project and its dependencies #17
Comments
Hi! We have some apps in JDK 8. So, for making your proposed changes, we will have to branch JDK 8 version. I'll do it (and your PR's) next week. Thanks! |
Great to hear that you are actively maintaining the library. Indeed, the option of maintaining 2 branches for the library is easy to implement and it will fix the problem in the short run. I would propose looking into the Multi Release feature via the maven-compiler-plugin. There should also be a Multi-Release JAR Check. I, personally, never implemented it, however, I am willing to look into it and if it's not too much work, I could even supply a working version of the library for you to test out within your applications (JDK 8) and we can work towards a stable release deployment. PS: I am not the author of PR #5. After checking the changes within that branch, there are many aesthetic changes, like replacing spaces with Did you already know about the multi-release? What do you think about it? Do you think it is worth the extra hassle to keep the library in sync via JDK + maven? |
I'm not aware of the multi-release. I know supporting JDK 8 nowadays may seem a loss of time and effort, but still there are some applications using it. However, I'd rather suggest to move to JDK 9 (or 11) and don't mess the library with some compatibility hacks that won't last for too long. So, our plans is to upgrade our applications to, at least, JDK 11, so that multi-release version won't be necessary. Said that, It's only my opinion. If you find a working version compatible with JDK 8 that we can use would be very helpful for us, giving us extra time to upgrade our applications. For this repo, I suggest keeping a JDK 8 branch, and move main branch to supported JDK versions. What do you thing? |
Awesome, raising the java minimum requirement to JDK11 is fine with me. I don't have any good argument to keep JDK 8 support alive. Ping me here, when you have the JDK11 branch ready.
EDIT: I would recommend the following repo management changes:
What do you think? |
Run: ./mvnw clean verify -P sources,javadoc Changes: - Upgrade lombok for [JDK11 support](https://projectlombok.org/setup/maven) - Add pluginManagement to force the maven plugin versions - Add sources & javadoc profiles for the release phase
Check out my changes and let me know to which branch would you like the PR |
Great! Since the main branch must contain jdk11+, in my opinion, I'd suggest to create a JDk1.8 branch. Agree with the management changes. |
Thanks a lot for sharing this library.
Would you be open to a PR for adding module-info.java to the project and its dependencies (
lti-13-core
<i-13-jwt
)?The most important changes would be:
I would be willing to also configure Github actions to help you accept PR like #5 faster and easier.
The text was updated successfully, but these errors were encountered: