Added typing to command_utils.py #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
complete direction-change: command_utils.py is no longer necessary, as all of the bot's commands use interactions instead (which can be deferred with a "thinking" message as part of Discord's UI, instead of using reactions). The only place it's used is the unimplemented/ folder. Could you just delete the file instead? |
|
I had thought about this when I was editing it... should have thought harder |
andrewj-brown
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added types to
utils/command_utils.pyto slowly help complete #134. I did have to useAnytypes twice for the decorator. Once is for*args, which seems reasonable. However, I had to also use it forself, which seems to be the easiest solution, given https://stackoverflow.com/a/69528375. I'd like to hear what others think.I also removed the check for the bot, as the type system recommends that this is no longer necessary.