Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fun messages on race conclusion (Issue #118) #208

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

GoldenRedstone
Copy link
Contributor

This adds short messages with the winner announcement when a snail race is completed. There are three categories: proper winner, tie, and no contest. A no contest result occurs when only a single snail competes in a race. This PR resolves #118, and as such it pokes fun at single snail races.
I decided to make winner announcements quite short and simple, and tie announcements messages exciting and potentially call for a rematch.
Feel free to let me know if there are any messages you think should be included or you don't feel should be included.

49Indium
49Indium previously approved these changes Jul 25, 2024
Copy link
Member

@49Indium 49Indium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'll leave it for a few days in case anyone else has comments. I really enjoy changes (like this one) that bring life to the bot.

Copy link
Member

@49Indium 49Indium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@49Indium 49Indium merged commit 84cb77c into UQComputingSociety:main Jul 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poke fun at single snail races
2 participants