allow for cereal to be applied to template classes with multiple arguments #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzothAmmo
added a commit
that referenced
this pull request
Mar 1, 2016
See #141 Should work across all compilers we currently support, for any other times when templated types are needed in a macro, just unroll the macro manually and replace as necessary
|
Original PR was from a while ago so it was easier to do this one by hand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses VA_ARGS instead of T in the macro argument list to allow for template classes with multiple arguments. I think it should be strictly more functionality and not break anything that worked before (but I might be wrong). Also, I didn't touch CEREAL_REGISTER_TYPE_WITH_NAME because I would have had to switch the argument order in the macro to use VA_ARGS, which would definitely break things.