Smol updates #330
Smol updates #330
Conversation
ehinman
commented
Aug 18, 2023
ehinman
commented
- updates following NP discussion, plus some small figure changes
- adds up whatever is present in each equation, do not need all subspecies - if one subspecies present, will use that to provide total n measure - shows subspecies used to get to total in TADA.NutrientSummationEquation column
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #330 +/- ##
===========================================
+ Coverage 55.17% 55.24% +0.07%
===========================================
Files 11 11
Lines 2784 2784
===========================================
+ Hits 1536 1538 +2
+ Misses 1248 1246 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I realized that if the equation accepts any combination of subsets of subspecies, other equations later in the hierarchy might be completely skipped even though a more complete set of subspecies exist. To fix this, I had to basically give the function every possible combination of nutrient subspecies, in a larger hierarchy. This is now saved as a .csv in the package.
|
I realized that if the equation accepts any combination of subsets of subspecies, other equations later in the hierarchy might be completely skipped even though a more complete set of subspecies exist to evaluate a later equation. To fix this, I had to basically give the function every possible combination of nutrient subspecies summations, in a larger hierarchy, and have each loop look for situations where ALL subspecies are present. This is now saved as a .csv in the package (NP_equations.csv). For example, if a nutrient grouping on a single day/site had NITRATE and AMMONIA, because the TKN + NITRATE + NITRITE equation comes earlier in the hierarchy, the function would accept ONLY NITRATE to represent TOTAL N, when really it should skip down to the AMMONIA + NITRATE + NITRITE equation and work with those subspecies together. This is now fixed, and it will sum AMMONIA and NITRATE, as intended. |
