515-flag-column-values-are-inconsistent-rejected-invalid-suspect-vs-accepted-valid-pass-1 #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using 'Suspect' and 'Pass' for consistency.
Closed
8 tasks
other changes to documentations for 'invalid' text to 'suspect' text.
|
@hillarymarler @cristinamullin This should be ready for review now. Ensuring that all the flagging function outputs are accurate and any documentation/comment changes (changing any instances of 'invalid' or 'rejected' to 'suspect' and any instances of 'valid' or 'accepted' to 'pass') where appropriate should be done as part of the review process. |
|
@wokenny13 can you write up a brief overview for TADA users - which functions are impacted and which specific values within the columns created by those functions? This will help them update their workflows to be compatible (a crosswalk from old to new names may be helpful). I'll share it with our contact list after this PR is merged in. Thank you in advance! |
hillarymarler
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using 'Suspect' and 'Pass' for consistency.