Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingest for KaguyaTC SP Support Data #4668

Closed
jlaura opened this issue Nov 4, 2021 · 2 comments
Closed

Add ingest for KaguyaTC SP Support Data #4668

jlaura opened this issue Nov 4, 2021 · 2 comments
Assignees

Comments

@jlaura
Copy link
Collaborator

jlaura commented Nov 4, 2021

Description
The kaguyatc2isis application is performing checks to determine the release of different TC data sets. Right now, the SP Support data are not supported because 'SLN-L-TC-3-SP-SUPPORT-LEVEL2B0-V1.0' is not included in the list of supported data types. Simply modifying the KaguyaTC label to alter that string to be a supported data type allows ingest.

I believe that the above string simply needs to be added to the list of ids that can be processed by kaguyatc2isis.

It also does not look like we are testing all of the different ingest flavors in our tests. This change should probably also include a test update for the SP Support data.

Here is an example label (the img is at the same URL, just saw lbl for img): https://data.darts.isas.jaxa.jp/pub/pds3/sln-l-tc-3-sp-support-level2b0-v1.0/20071207/data/TC1S2B0_01_00721S200E1414.lbl

@ladoramkershner
Copy link
Contributor

@jlaura can this issue be closed with the merging of #4688 ?

@jlaura
Copy link
Collaborator Author

jlaura commented Mar 28, 2022

Yup! Closed by #4688 and available in ISIS7.0

@jlaura jlaura closed this as completed Mar 28, 2022
@jlaura jlaura self-assigned this Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants