Excessive Compiler Warnings for Qt Deprecations

[KrisBecker]

ISIS version(s) affected: 7.1.0+

Description
Throughout compilation of ISIS on MacOSX 10.15.7 Catalina, there are significant streams of warnings generated about Qt deprecations. These warnings occur for many if not all compilations. Here is an example of a single file/compile:

[3641/3667] Building CXX object tests/CMakeFiles/runISISTests.dir/FunctionalTestsTgocassisunstitch.cpp.o
In file included from /Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/isis/tests/FunctionalTestsTgocassisunstitch.cpp:3:
In file included from /Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/build/inc/tgocassisunstitch.h:5:
In file included from /Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/build/inc/UserInterface.h:11:
In file included from /Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/build/inc/IsisAml.h:18:
In file included from /Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/build/inc/IsisXMLApplication.h:9:
In file included from /Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/build/inc/IsisAmlData.h:12:
/Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/build/inc/CubeAttribute.h:263:56: warning: 'split' is deprecated: Use Qt::SplitBehavior variant instead [-Wdeprecated-declarations]
        QStringList attributes = fileName.attributes().split("+", QString::SkipEmptyParts);
                                                       ^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtCore/qstring.h:608:23: note: 'split' has been explicitly marked deprecated here
    Q_REQUIRED_RESULT QT_DEPRECATED_VERSION_X_5_15("Use Qt::SplitBehavior variant instead")
                      ^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtCore/qglobal.h:374:45: note: expanded from macro 'QT_DEPRECATED_VERSION_X_5_15'
# define QT_DEPRECATED_VERSION_X_5_15(text) QT_DEPRECATED_X(text)
                                            ^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'
#  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)
                                ^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtCore/qcompilerdetection.h:675:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'
#    define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))
                                                      ^
In file included from /Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/isis/tests/FunctionalTestsTgocassisunstitch.cpp:6:
In file included from /Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/isis/tests/TestUtilities.h:20:
/Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/build/inc/CSVReader.h:140:17: warning: 'split' is deprecated: Use Qt::SplitBehavior variant instead [-Wdeprecated-declarations]
            str.split(delimiter, keepEmptyParts? QString::KeepEmptyParts : QString::SkipEmptyParts);
                ^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtCore/qstring.h:614:23: note: 'split' has been explicitly marked deprecated here
    Q_REQUIRED_RESULT QT_DEPRECATED_VERSION_X_5_15("Use Qt::SplitBehavior variant instead")
                      ^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtCore/qglobal.h:374:45: note: expanded from macro 'QT_DEPRECATED_VERSION_X_5_15'
# define QT_DEPRECATED_VERSION_X_5_15(text) QT_DEPRECATED_X(text)
                                            ^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'
#  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)
                                ^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtCore/qcompilerdetection.h:675:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'
#    define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))
                                                      ^
In file included from /Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/isis/tests/FunctionalTestsTgocassisunstitch.cpp:7:
In file included from /Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/build/inc/Histogram.h:14:
In file included from /Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/build/inc/Statistics.h:16:
/Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/build/inc/XmlStackedHandler.h:118:36: warning: 'QXmlDefaultHandler' is deprecated [-Wdeprecated-declarations]
  class XmlStackedHandler : public QXmlDefaultHandler {
                                   ^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtXml/qxml.h:407:7: note: 'QXmlDefaultHandler' has been explicitly marked deprecated here
class QT_DEPRECATED_VERSION(5, 15) Q_XML_EXPORT QXmlDefaultHandler : public QXmlContentHandler,
      ^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtCore/qglobal.h:393:45: note: expanded from macro 'QT_DEPRECATED_VERSION'
#define QT_DEPRECATED_VERSION(major, minor) QT_DEPRECATED_VERSION_##major##_##minor
                                            ^
<scratch space>:143:1: note: expanded from here
QT_DEPRECATED_VERSION_5_15
^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtCore/qglobal.h:375:45: note: expanded from macro 'QT_DEPRECATED_VERSION_5_15'
# define QT_DEPRECATED_VERSION_5_15         QT_DEPRECATED
                                            ^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'
#  define QT_DEPRECATED Q_DECL_DEPRECATED
                        ^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtCore/qcompilerdetection.h:227:45: note: expanded from macro 'Q_DECL_DEPRECATED'
#  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))
                                            ^
In file included from /Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/isis/tests/FunctionalTestsTgocassisunstitch.cpp:7:
In file included from /Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/build/inc/Histogram.h:14:
In file included from /Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/build/inc/Statistics.h:16:
/Users/kbecker/ISIS/Isis4Dev/PDARTs/Nov022022/ISIS3/build/inc/XmlStackedHandler.h:135:29: warning: 'QXmlParseException' is deprecated [-Wdeprecated-declarations]
      bool fatalError(const QXmlParseException &exception);
                            ^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtXml/qxml.h:226:7: note: 'QXmlParseException' has been explicitly marked deprecated here
class QT_DEPRECATED_VERSION(5, 15) Q_XML_EXPORT QXmlParseException
      ^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtCore/qglobal.h:393:45: note: expanded from macro 'QT_DEPRECATED_VERSION'
#define QT_DEPRECATED_VERSION(major, minor) QT_DEPRECATED_VERSION_##major##_##minor
                                            ^
<scratch space>:96:1: note: expanded from here
QT_DEPRECATED_VERSION_5_15
^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtCore/qglobal.h:375:45: note: expanded from macro 'QT_DEPRECATED_VERSION_5_15'
# define QT_DEPRECATED_VERSION_5_15         QT_DEPRECATED
                                            ^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'
#  define QT_DEPRECATED Q_DECL_DEPRECATED
                        ^
/Users/kbecker/miniconda3/envs/Nov022022/include/qt/QtCore/qcompilerdetection.h:227:45: note: expanded from macro 'Q_DECL_DEPRECATED'
#  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))
                                            ^
4 warnings generated.

The version of Qt installed is:

qt                        5.15.3               hb3ad848_0    conda-forge
qt-main                   5.15.3               h938c29d_0    conda-forge
qt-webengine              5.15.4               h72ca1e5_3    conda-forge
qwt                       6.2.0                h4cc5820_4    conda-forge

[AustinSanders]

For now, we can pin to a previous version. Moving forward, this will need to be fixed.

[antonhibl]

@AustinSanders made a PR to pin the version (#5085)[https://github.com//pull/5085]