Refactor lrowaccal for testability and add a radiance units label to the output cube #4940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add radiance units label in lrowaccal output cube
…its to output PVL
…tions to lambdas with captures
…put cube units label changes
- Merge branch 'dev-lrowaccal-unitsfix-tests' of https://github.com/lrocdev/ISIS3 into dev-lrowaccal-unitsfix-tests
… is not inserted for RadiometricType IOF
jessemapel
reviewed
May 4, 2022
jessemapel
reviewed
May 5, 2022
jessemapel
approved these changes
May 11, 2022
Kelvinrr
pushed a commit
to gsn9/ISIS3
that referenced
this pull request
Jul 18, 2022
…the output cube (DOI-USGS#4940) * Add radiance units label in lrowaccal output cube * Refactor lrowaccal app to be callable for testing and add radiance units to output PVL * Update formatting and NULL initialization * Add NULL assignments after deletions * Add CubeAttributeOutput to output cube initialization * Add functional test for lrowaccal units label addition and accompanying test cube * Refactor lrowaccal to remove global variables and convert helper functions to lambdas with captures * Update history section of lrowaccal XML file with refactoring and output cube units label changes * Remove old lrowaccal Makefile tests * Add lrowaccal functional test to ensure that the radiance units label is not inserted for RadiometricType IOF * Add Cordell Michaud to the .zenodo.json document * Add lrowaccal changes to CHANGELOG.md * Clean up lrowaccal includes and leftover comment * Re-add lrowaccal Makefile tests * Re-add disclaimer to top of lrowaccal's main.cpp file * Add input attributes retrieval to lrowaccal.cpp * Fix lrowaccal functional test error messages and add PVl group and existence checks * Move lrowaccal units change message to Changed sub-header in CHANGELOG.md * Simplify lrowaccal functional test assertions Co-authored-by: Victor Silva <victor.silva@asu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
#4939
Motivation and Context
This change adds a radiance units label to the output cube of lrowaccal as suggested by the LROC science team to more clearly indicate the radiance units and accompany a change to the radiance calibration coefficients to make the radiance units match those of the NAC.
This change also brings lrowaccal in line with the newer testing framework for ISIS and covers the units label change with functional tests.
How Has This Been Tested?
Functional tests were added to
isis/tests/FunctionalTestsLrowaccal.cppto cover the units label change and ensure the label is only added when the RadiometricType parameter is Radiance.The change was also tested and validated by the science team at LROC alongside the change to the radiance calibration coefficients.
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: