Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team Cog Fixes #10

Merged
merged 3 commits into from
Mar 2, 2024
Merged

Team Cog Fixes #10

merged 3 commits into from
Mar 2, 2024

Conversation

eluric
Copy link
Contributor

@eluric eluric commented Mar 2, 2024

Previously, after merging into main, interactions were timing out despite it working fine on the test bot. Discord expects all interactions to be responded to within 3 seconds but the main bot was taking longer than expected even though all the other code had been executed in time. The exact cause of the lack of response is unclear but I suspect it has something to do with latency issues on fly.io.

The fix in this case was to instead defer all interactions which lets Discord know that the interaction has been acknowledged and will be responded to at a later time. This "later" response is still the same as the original code but deferring should fix the timeout issues.

Copy link
Contributor

@SkellyBG SkellyBG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice work!

@eluric eluric merged commit 6bd7e34 into main Mar 2, 2024
1 check passed
@eluric eluric deleted the team-fixes branch March 2, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants