Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open views to investigators #789

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Open views to investigators #789

wants to merge 18 commits into from

Conversation

amstilp
Copy link
Contributor

@amstilp amstilp commented Oct 23, 2024 •
edited
Loading

  • Update templates to show less to "view" users (since templates were initially written when only DCC staff would access them). This includes removing buttons, links, etc, that wouldn't work for them or that they shouldn't see.
  • Allow "view" users to see the UploadCycleDetail and UploadCycleList pages

Still to do:

@amstilp
Map authenticated users to a Django group
bda2416 
This will let us grant that group view permission.
@amstilp
Switch UploadCycleDetail to be visible by View users
0c8e129 
Modify tests to use a view user by default. Change test structure for
checking links by having one test for view users, one for staff
view, and one for edit users; these tests check if the proper links
are or are not shown.
@amstilp
Make the upload cycle detail page a bit prettier
8ae5e00
@amstilp
Show an alert indicating if the upload cycle is current, past, or future
8ed852f
@amstilp
Switch icon for combined workspace
772b209
@amstilp
Only show upload cycle notes to staff users
552f332
@amstilp
Only UploadWorkspaceDetail links to users with access
b33c940
@amstilp
Allow view users to see UploadCycleList
8d60961
@amstilp
Add content to the home page
70c1912 
Finally remove the under construction message! Add links to the
upload cycles and to the workspace landing page.
@amstilp
Add description and links to home page
b7fc012 
Remove the "under construction" message! Add descriptive text and
some links to the upload cycle list and the workspace landing page.
@amstilp
Wording modifications
68fb593
@amstilp
Show combined workspace before upload workspaces
33bc3bb
@amstilp
Show accordions uncollapsed by default
839f004
@amstilp
Only show combined and upload workspaces to view users
bd85e08
@amstilp
Merge branch 'main' into feature/open-views-to-investigators
9cd4d00
@amstilp
Update workspace detail pages for view users
17d0935 
Now that all authenticated users will be getting view permission,
we need to make sure that the workspace detail pages only contain
information and links that they should see. Update workspace detail
page and tests as appropriate.
@amstilp
Improve tests checking for main ACM index link
dc6df37
@amstilp
Run ruff format
173831c
@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 99.53271% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.70%. Comparing base (e50af32) to head (173831c).

Files with missing lines Patch % Lines
...emplates/gregor_anvil/releaseworkspace_detail.html 77.77% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #789      +/-   ##
==========================================
+ Coverage   98.53%   98.70%   +0.17%     
==========================================
  Files         162      162              
  Lines       20503    20823     +320     
==========================================
+ Hits        20203    20554     +351     
+ Misses        300      269      -31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amstilp