fix tests

test/test_grid.py

@@ -952,13 +952,6 @@ def test_populate_bounds_GCA_mix(self):
         face_bounds = bounds_xarray.values
         nt.assert_allclose(grid.bounds.values, expected_bounds, atol=ERROR_TOLERANCE)
 
-    def test_populate_bounds_MPAS(self):
-        xrds = xr.open_dataset(self.gridfile_mpas)
-        uxgrid = ux.Grid.from_dataset(xrds, use_dual=True)
-        bounds_xarray = uxgrid.bounds
-        pass
-
-
     def test_opti_bounds(self):
         uxgrid = ux.open_grid(gridfile_CSne8)
         bounds = uxgrid.bounds

uxarray/grid/arcs.py

@@ -2,7 +2,7 @@
 
 # from uxarray.grid.coordinates import node_xyz_to_lonlat_rad, normalize_in_place
 
-from uxarray.grid.coordinates import _xyz_to_lonlat_rad_no_norm
+from uxarray.grid.coordinates import _xyz_to_lonlat_rad_no_norm, _normalize_xyz_scalar
 from uxarray.constants import ERROR_TOLERANCE
 
 from uxarray.utils.computing import isclose, cross, dot
@@ -309,7 +309,7 @@ def extreme_gca_latitude(gca_cart, extreme_type):
 
     if 0 < d_a_max < 1:
         node3 = (1 - d_a_max) * n1 + d_a_max * n2
-        # node3 = np.array(_normalize_xyz(node3[0], node3[1], node3[2]))
+        node3 = np.array(_normalize_xyz_scalar(node3[0], node3[1], node3[2]))
         d_lat_rad = np.arcsin(np.clip(node3[2], -1, 1))
 
         return (

uxarray/grid/coordinates.py

@@ -149,6 +149,15 @@ def _normalize_xyz(
     return x_norm, y_norm, z_norm
 
 
+@njit
+def _normalize_xyz_scalar(x: float, y: float, z: float):
+    denom = np.linalg.norm(np.asarray(np.array([x, y, z]), dtype=np.float64), ord=2)
+    x_norm = x / denom
+    y_norm = y / denom
+    z_norm = z / denom
+    return x_norm, y_norm, z_norm
+
+
 def _populate_node_latlon(grid) -> None:
     """Populates the latitude and longitude coordinates of a Grid (`node_lon`,
     `node_lat`)"""