Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UXARRAY/uxarray#862 #863

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix UXARRAY/uxarray#862 #863

merged 1 commit into from
Jul 22, 2024

Conversation

kjnam
Copy link
Contributor

@kjnam kjnam commented Jul 22, 2024

This commit removes an unnecessary set of parentheses around isel, which creates a tuple, causing an error later in the UxDataArray construction.

Overview

Expected Usage

No change in usage.

PR Checklist

General

  • An issue is linked created and linked
  • Add appropriate labels
  • Filled out Overview and Expected Usage (if applicable) sections

Testing

  • Adequate tests are created if there is new functionality
  • Tests cover all possible logical paths in your function
  • Tests are not too basic (such as simply calling a function and nothing else)

Documentation

  • Docstrings have been added to all new functions
  • Docstrings have updated with any function changes
  • Internal functions have a preceding underscore (_) and have been added to docs/internal_api/index.rst
  • User functions have been added to docs/user_api/index.rst

Examples

  • Any new notebook examples added to docs/examples/ folder
  • Clear the output of all cells before committing
  • New notebook files added to docs/examples.rst toctree
  • New notebook files added to new entry in docs/gallery.yml with appropriate thumbnail photo in docs/_static/thumbnails/

The commit removes an unnecessary set of parentheses around isel, which
creates a tuple, causing an error later.
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for catching and fixing this!

@kjnam
Copy link
Contributor Author

kjnam commented Jul 22, 2024

@erogluorhan No problem. It seems I am hitting edge cases that are not being tested. Thanks for the great work.

Copy link
Member

@philipc2 philipc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and once again for catching these bugs!

@philipc2 philipc2 merged commit 170e035 into UXARRAY:main Jul 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants