Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UXarray Themed Colormaps #873

Merged
merged 18 commits into from
Aug 23, 2024
Merged

UXarray Themed Colormaps #873

merged 18 commits into from
Aug 23, 2024

Conversation

aaronzedwick
Copy link
Member

@aaronzedwick aaronzedwick commented Aug 1, 2024

Closes #786

Overview

Adds two UXarray-styled colormaps: diverging and sequential.
Diverging:
image
Sequential:
image

Expected Usage

import uxarray as ux

uxds = ux.open_dataset(grid_path, data_path)

uxds[v1].plot(cmap=ux.cmaps.sequential, backend='matplotlib')

uxds[v1].plot(cmap=ux.cmaps.diverging, backend='matplotlib')

PR Checklist

General

  • An issue is linked created and linked
  • Add appropriate labels
  • Filled out Overview and Expected Usage (if applicable) sections

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

uxarray/cmaps.py Outdated Show resolved Hide resolved
@philipc2
Copy link
Member

philipc2 commented Aug 1, 2024

Also from the usage example in the overview, it should be something like the following:

import uxarray as ux

uxds[v1].plot(cmap=ux.cmaps.sequential, backend='matplotlib')

uxds[v1].plot(cmap=ux.cmaps.diverging, backend='matplotlib')

@philipc2
Copy link
Member

philipc2 commented Aug 1, 2024

The addition to the user guide section also appears to be failing.

image

@aaronzedwick
Copy link
Member Author

aaronzedwick commented Aug 2, 2024

How do you think the colors look? @rajeeja @philipc2

@rajeeja
Copy link
Contributor

rajeeja commented Aug 2, 2024

How do you think the colors look? @rajeeja @philipc2

👍

@philipc2
Copy link
Member

@aaronzedwick

The colormaps look great, but I'm wondering if maybe we would like to consider different colors all together for the style of Uxarray?

We still don't have a true package logo. Would you like to sit down together (including @rajeeja too) to brainstorm some ideas for the theme of Uxarray?

For the text of the logo, I was considering something like the following.

image

For reference, xarray:

image

It would be nice to put together a style guide for our package, logos, and design. Something like:

image

@philipc2
Copy link
Member

I've always liked the idea of this style of logo, which emphasizes the spherical unstructured grid support we provide.

image

@philipc2
Copy link
Member

We could also adapt the Project Raijin logo for UXarray, which I think looks quite nice. We could modify the colors too.

image

@aaronzedwick
Copy link
Member Author

We could also adapt the Project Raijin logo for UXarray, which I think looks quite nice. We could modify the colors too.

image

I like these colors a lot more than the other ones.

@philipc2
Copy link
Member

Here are the colors from the new logo if you'd like to update these colormaps:

Blue:
#016691

Green:
#049390

Gray:
#343741

@rajeeja
Copy link
Contributor

rajeeja commented Aug 15, 2024

@aaronzedwick

The colormaps look great, but I'm wondering if maybe we would like to consider different colors all together for the style of Uxarray?

We still don't have a true package logo. Would you like to sit down together (including @rajeeja too) to brainstorm some ideas for the theme of Uxarray?

For the text of the logo, I was considering something like the following.

image For reference, xarray: image It would be nice to put together a style guide for our package, logos, and design. Something like:

image

+1 let's get this done Friday at UChicago.

@aaronzedwick
Copy link
Member Author

aaronzedwick commented Aug 15, 2024

@philipc2 I really like how these came out.

image
image
image

@philipc2
Copy link
Member

@philipc2 I really like how these came out.

image image image

These are very pretty!

One small nitpick: can you make the blue & green ones start at zero (white)?

@philipc2
Copy link
Member

Can you see how a colormap would look if it's a White -> Green -> Blue sequence?

A lot of the sequential ones on mpl appear to start with white.

image

@aaronzedwick
Copy link
Member Author

@philipc2 I really like how these came out.
image image image

These are very pretty!

One small nitpick: can you make the blue & green ones start at zero (white)?

Oh yeah that would be important!

Copy link
Member

@philipc2 philipc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great here! Once we have the following color maps, it'll be ready!

  • Sequential: White, Blue, Green
  • Sequential: White, Blue
  • Sequential: White, Green
  • Diverging: Blue, White, Green

@aaronzedwick
Copy link
Member Author

image
What do you wanna call this one then?

@aaronzedwick
Copy link
Member Author

Everything looks great here! Once we have the following color maps, it'll be ready!

  • Sequential: White, Blue, Green
  • Sequential: White, Blue
  • Sequential: White, Green
  • Diverging: Blue, White, Green

The blue looks darker to me so I think it makes more sense to go green-blue with the colors.

@aaronzedwick aaronzedwick requested a review from philipc2 August 19, 2024 13:29
@philipc2
Copy link
Member

image

Can we also add edges to this plot? Maybe a title would be good too for each.

Copy link
Member

@philipc2 philipc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These colormaps look great! Thanks for putting them together.

@philipc2 philipc2 merged commit 38ae001 into main Aug 23, 2024
20 checks passed
@aaronzedwick aaronzedwick deleted the zedwick/color-map branch November 21, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UXarray Themed Colormap
3 participants