Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CITATION.cff: Remove duplicate entries, add Rachel, add lacking ORCID IDs #910

Merged
merged 13 commits into from
Aug 28, 2024
Merged

CITATION.cff: Remove duplicate entries, add Rachel, add lacking ORCID IDs #910

merged 13 commits into from
Aug 28, 2024

Conversation

erogluorhan
Copy link
Member

@erogluorhan erogluorhan commented Aug 27, 2024 •
edited
Loading

Simple changes to

  • remove a duplicate author entry
  • add Amber and Rachel
  • add ORCID IDs for multiple folks

@erogluorhan erogluorhan requested a review from philipc2 August 27, 2024 20:37
@erogluorhan erogluorhan marked this pull request as draft August 27, 2024 20:37
@erogluorhan
Copy link
Member Author

@philipc2 per our UXarray meeting today, folks will provide me with their ORCID IDs, and I will add them here

@erogluorhan erogluorhan changed the title CITATION.cff: Remove duplicate entry CITATION.cff: Remove duplicate entries, add Rachel, add lacking ORCID IDs Aug 27, 2024
@erogluorhan erogluorhan marked this pull request as ready for review August 28, 2024 04:40
@erogluorhan
Copy link
Member Author

@philipc2 @rajeeja This is now ready for review.
@aaronzedwick feel free to add your ORCID with a commit or let me know it and I can add.

philipc2
philipc2 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@philipc2 philipc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me!

@aaronzedwick
Copy link
Member

@philipc2 @rajeeja This is now ready for review. @aaronzedwick feel free to add your ORCID with a commit or let me know it and I can add.

My ID is 0000-0003-3229-3381. Thanks!

@erogluorhan
Copy link
Member Author

@philipc2 @rajeeja This is now ready for review. @aaronzedwick feel free to add your ORCID with a commit or let me know it and I can add.

My ID is 0000-0003-3229-3381. Thanks!

Added, thanks! Please review when you have time

aaronzedwick
aaronzedwick approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@aaronzedwick aaronzedwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry ignore that last review, I was signed into my school account briefly and forgot to sign out.

@erogluorhan erogluorhan merged commit 6d87a71 into main Aug 28, 2024
20 checks passed
@erogluorhan erogluorhan deleted the zenodo branch December 2, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apliberty apliberty apliberty approved these changes

@aaronzedwick aaronzedwick aaronzedwick approved these changes

@philipc2 philipc2 philipc2 approved these changes

@rajeeja rajeeja Awaiting requested review from rajeeja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erogluorhan @aaronzedwick @philipc2 @apliberty @rajeeja