Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASV CI Fixes #912

Merged
merged 3 commits into from
Aug 28, 2024
Merged

ASV CI Fixes #912

merged 3 commits into from
Aug 28, 2024

Conversation

philipc2
Copy link
Member

@philipc2 philipc2 commented Aug 28, 2024

Closes #913

Overview

@philipc2 philipc2 self-assigned this Aug 28, 2024
@philipc2 philipc2 added the run-benchmark Run ASV benchmark workflow label Aug 28, 2024
@philipc2
Copy link
Member Author

@rajeeja

This appears to be the root of the issue we've been encountering.

pypa/build#803

Copy link

ASV Benchmarking

Benchmark Comparison Results

Benchmarks that have improved:

Change Before [b346270] After [c6368e9] Ratio Benchmark (Parameter)
- 406M 354M 0.87 mpas_ocean.Integrate.peakmem_integrate('480km')

Benchmarks that have stayed the same:

Change Before [b346270] After [c6368e9] Ratio Benchmark (Parameter)
380M 380M 1 face_bounds.FaceBounds.peakmem_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/mpas/QU/oQU480.231010.nc'))
381M 381M 1 face_bounds.FaceBounds.peakmem_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/scrip/outCSne8/outCSne8.nc'))
385M 383M 0.99 face_bounds.FaceBounds.peakmem_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/ugrid/geoflow-small/grid.nc'))
383M 381M 0.99 face_bounds.FaceBounds.peakmem_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/ugrid/quad-hexagon/grid.nc'))
1.35±0.01s 1.33±0s 0.98 face_bounds.FaceBounds.time_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/mpas/QU/oQU480.231010.nc'))
173±0.7ms 177±2ms 1.02 face_bounds.FaceBounds.time_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/scrip/outCSne8/outCSne8.nc'))
1.64±0.01s 1.62±0s 0.99 face_bounds.FaceBounds.time_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/ugrid/geoflow-small/grid.nc'))
7.74±0.1ms 7.64±0.03ms 0.99 face_bounds.FaceBounds.time_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/ugrid/quad-hexagon/grid.nc'))
1.69±0.01s 1.70±0.01s 1.01 import.Imports.timeraw_import_uxarray
634±4ms 639±3ms 1.01 mpas_ocean.ConnectivityConstruction.time_face_face_connectivity('120km')
39.9±0.4ms 39.4±0.6ms 0.99 mpas_ocean.ConnectivityConstruction.time_face_face_connectivity('480km')
1.85±0.02ms 1.87±0.02ms 1.01 mpas_ocean.ConnectivityConstruction.time_n_nodes_per_face('120km')
500±8μs 470±4μs 0.94 mpas_ocean.ConnectivityConstruction.time_n_nodes_per_face('480km')
1.19±0μs 1.17±0μs 0.98 mpas_ocean.ConstructTreeStructures.time_ball_tree('120km')
295±2ns 296±4ns 1 mpas_ocean.ConstructTreeStructures.time_ball_tree('480km')
779±4ns 790±3ns 1.01 mpas_ocean.ConstructTreeStructures.time_kd_tree('120km')
281±2ns 282±5ns 1 mpas_ocean.ConstructTreeStructures.time_kd_tree('480km')
398M 398M 1 mpas_ocean.GeoDataFrame.peakmem_to_geodataframe('120km', False)
387M 387M 1 mpas_ocean.GeoDataFrame.peakmem_to_geodataframe('120km', True)
362M 362M 1 mpas_ocean.GeoDataFrame.peakmem_to_geodataframe('480km', False)
361M 361M 1 mpas_ocean.GeoDataFrame.peakmem_to_geodataframe('480km', True)
1.04±0s 1.04±0s 1 mpas_ocean.GeoDataFrame.time_to_geodataframe('120km', False)
57.9±0.6ms 58.0±0.5ms 1 mpas_ocean.GeoDataFrame.time_to_geodataframe('120km', True)
78.3±1ms 76.0±0.3ms 0.97 mpas_ocean.GeoDataFrame.time_to_geodataframe('480km', False)
5.43±0.1ms 5.40±0.1ms 0.99 mpas_ocean.GeoDataFrame.time_to_geodataframe('480km', True)
263M 263M 1 mpas_ocean.Gradient.peakmem_gradient('120km')
240M 240M 1 mpas_ocean.Gradient.peakmem_gradient('480km')
2.68±0.01ms 2.66±0.01ms 0.99 mpas_ocean.Gradient.time_gradient('120km')
281±2μs 280±0.6μs 1 mpas_ocean.Gradient.time_gradient('480km')
370M 370M 1 mpas_ocean.Integrate.peakmem_integrate('120km')
176±1ms 179±0.9ms 1.01 mpas_ocean.Integrate.time_integrate('120km')
12.0±0.03ms 11.8±0.06ms 0.99 mpas_ocean.Integrate.time_integrate('480km')
345±2ms 348±3ms 1.01 mpas_ocean.MatplotlibConversion.time_dataarray_to_polycollection('120km', 'exclude')
343±3ms 345±4ms 1 mpas_ocean.MatplotlibConversion.time_dataarray_to_polycollection('120km', 'include')
345±1ms 341±2ms 0.99 mpas_ocean.MatplotlibConversion.time_dataarray_to_polycollection('120km', 'split')
21.4±0.2ms 21.7±0.2ms 1.02 mpas_ocean.MatplotlibConversion.time_dataarray_to_polycollection('480km', 'exclude')
21.8±0.3ms 21.9±0.3ms 1 mpas_ocean.MatplotlibConversion.time_dataarray_to_polycollection('480km', 'include')
22.0±0.3ms 21.5±0.3ms 0.98 mpas_ocean.MatplotlibConversion.time_dataarray_to_polycollection('480km', 'split')
54.8±0.1ms 58.7±0.3ms 1.07 mpas_ocean.RemapDownsample.time_inverse_distance_weighted_remapping
44.3±0.1ms 47.2±1ms 1.06 mpas_ocean.RemapDownsample.time_nearest_neighbor_remapping
360±0.8ms 379±2ms 1.05 mpas_ocean.RemapUpsample.time_inverse_distance_weighted_remapping
264±0.9ms 284±2ms 1.08 mpas_ocean.RemapUpsample.time_nearest_neighbor_remapping
236M 236M 1 quad_hexagon.QuadHexagon.peakmem_open_dataset
236M 236M 1 quad_hexagon.QuadHexagon.peakmem_open_grid
6.44±0.02ms 6.41±0.02ms 0.99 quad_hexagon.QuadHexagon.time_open_dataset
5.52±0.05ms 5.55±0.03ms 1.01 quad_hexagon.QuadHexagon.time_open_grid

@philipc2 philipc2 marked this pull request as ready for review August 28, 2024 01:57
@philipc2 philipc2 changed the title DRAFT: ASV CI Fixes ASV CI Fixes Aug 28, 2024
@philipc2 philipc2 requested a review from erogluorhan August 28, 2024 05:28
@philipc2 philipc2 merged commit b51e33e into main Aug 28, 2024
21 checks passed
@erogluorhan erogluorhan deleted the philipc2/asv-pr-ci branch December 2, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-benchmark Run ASV benchmark workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASV PR Workflow Failing
2 participants