Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshed logos - cleanup #917

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Refreshed logos - cleanup #917

merged 6 commits into from
Aug 28, 2024

Conversation

erogluorhan
Copy link
Member

Overview

  • Remove blue logos (we decided to use only horizontal and vertical layout logos with white and black "xarray" texts),
  • Rename dark and light logos ("h_dark" --> uxarray_logo-h-dark etc.),
  • Remove the older temporary logo (it's now archived in the drive)
  • Use website color scheme dependent logo themes, i.e. if dark website use white text logo, or vice versa

PR Checklist

General

  • Add appropriate labels
  • Filled out the Overview section

@erogluorhan erogluorhan added documentation Improvements or additions to documentation improvement Improvements on existing features or infrastructure labels Aug 28, 2024
Copy link
Member

@philipc2 philipc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the logo rename, there's a mixture of _ and - in the name.

uxarray_logo-h-dark.svg

I'd suggested one of the following options, with no preference.

uxarray_logo_h_dark.svg

or

uxarray-logo-h-dark.svg

README.md Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@erogluorhan
Copy link
Member Author

In the logo rename, there's a mixture of _ and - in the name.

uxarray_logo-h-dark.svg

I'd suggested one of the following options, with no preference.

uxarray_logo_h_dark.svg

or

uxarray-logo-h-dark.svg

You're right; done it now with all underscores.

@erogluorhan erogluorhan requested a review from philipc2 August 28, 2024 13:21
Copy link
Member

@philipc2 philipc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are great! Tested out the Light/Dark switching on both the README and ReadTheDocs and both are working as expected. Thanks for cleaning this up!

@philipc2 philipc2 merged commit ee1c02c into main Aug 28, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation improvement Improvements on existing features or infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants