-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refreshed logos - cleanup #917
Conversation
…eme dependent logo theme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the logo rename, there's a mixture of _
and -
in the name.
uxarray_logo-h-dark.svg
I'd suggested one of the following options, with no preference.
uxarray_logo_h_dark.svg
or
uxarray-logo-h-dark.svg
You're right; done it now with all underscores. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are great! Tested out the Light/Dark switching on both the README and ReadTheDocs and both are working as expected. Thanks for cleaning this up!
Overview
PR Checklist
General