COrrected name of *Add*LowerAtomic transform method #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaillet
added a commit
that referenced
this pull request
Apr 9, 2020
* Llvm 10 (#161) ## Initial pass at LLVM 10 support to get tests to pass ## Core Changes Additional work is needed to fully support LLVM10 changes - this is just the minimum bar tp get the ball rolling. * Added support for attributes with type parameter (IR-> managed only at this point, full support for new features later) * Updated triple bindings to support new triple components in LLVM10 ## Breaking Changes * TargetObjectFile removed in favor of TargetBinary as it isn't really an ObjectFile only anymore. (Follows underlying changes in LLVM and the LLVM-C APIs) * Removed DebugInfoFlags values no longer present in underlying LLVM definitions - DebugInfoFlags.BlockByrefStruct - DebugInfoFlags.MainSubProgram - DebugInfoFlags.Trivial * DiBuilder.CreateTypedef() now has an alignInBits parameter (For more details see release notes) ## Other changes * Added validation of input YAML with warnings for redundant or missing references * Updated license info to LLVM's new lic. * Fixed sample Kaleidoscope parser AST to corrrectly capture extern status of prototypes * replaced extension LibLLVM* extension functions with new official LLVM* functions * Added marking of deprecated functions in the interop API rather then deleting them outright, in case consumers are using it directly * Added Kind property to AtomicRMW instructions * Added IsWeak property to AtomicCmpXchg instructions * Added support for the Freeze instruction * Added additional Basic block insert/append methods * Added support for creating macro files and macros to DebugInfoBuilder * Removed C#8 features from bindings generator and forced project to framework defaults. This prevents hard to track compile/runtime fails if the language features require runtime support since the CppSHarp libs don't yet work on anything but net47 * Fixed handling of unsafe types in bindings generator * Made conversion of pointer to IntPtr explicit so that functions returning pointers are easier to detect * Updated type printer to not convert all pointer types to IntPtr so that conversion is explicit. * added new !Unsafe (and corresponding class YamlUnsafeReturn) to the configuration to explicitly allow unsafe return types on functions requiring them. (This suppresses the validation error for the specified function) * Updated config file with APIs requiring updates based on these changes * Updated DIFile to use official LLVM functions to get property values * Corrected nullability of scopes in Debug information * Removed more redundant LibLLVM* functions and replaced with official LLVM* Functions * Added more complete support for GlobalIFuncs, including module enumeration * removed dead code from tutorial samples * re-worked build scripts in prep for building llvm libs directly * Moved to a common project/repo neutral module to leverage common functions across repos in general * updated all the scripts to leverage new common module * Increased strictness level to help catch bugs in the scripts earlier * Updates for nullability and deprecated functions * Nuget updates * Added function pointer typedef (delegates) to the checks and marshaling support to ensure they are generated with a usable signature * Ran solution wide cleanup to fix style of refactored code. (#163) * Ran solution wide cleanup to fix style of refactored code. * Fixed common build to auto opt-in to module install on automated builds * Removed force parameter from Find-VSInstance Shifted to testing for EnvVar instead) * Corrected multiple path names for hashtable indexing * added llvm_10 branch to build YAML to allow validation of in progress work * Update samples for v10 (#165) - updated main program of Kaleidoscope samples to better use existing reactive pipeline support. (Cleans up construction of the pipeline) - Updated return type of the Generate method to use a new Optional<T> to indicate if a value was generated or not, instead of using a null value (or assuming the default value of a value type was never valid) * Updating Kaleidoscope samples (#166) * Replaced use of Observalbe with AsyncEnumerator as it is a more familiar flow and makes more sense for the REPL loops. This does add a bit more code to the sample program itself, but makes the error handling, parsing and generation more obvious. * Added ErrorNode to the AST so that errors are recorded in tho the AST instead of thrown as an exception. (The AST and parsing no longer throw errors except for unexpected runtime states (Not user input/syntax errors)) * Simplified error handling and code generator return types to use OptionalValue<T> instead of null references etc. to indicate the operation completed but has no new data. Added a unit test project (Currently empty) to flesh out unit testing of the samples to aid in validating their state and provide greater coverage of the core library itself. * Major refactoring of Kaleidoscope parser and grammar libraries - The parser is now entirely in the grammar assembly and the ANTLR support is internal to that library. (e.g. the use of ANTLR is encapsulated in the assembly as an implementation detail) * Test kaleidoscope (#167) * Re-factored Kaleidoscope and enabled testing of codegen * Kaleidoscope runtime now includes a generalized REPL abstract base class that eliminates a lot of duplicated code for each sample. * Shifted to a simpler synchronous IEnumerable as the Async adds complexity and potential problems with threading and LLVM thread unsafe Contexts * Added tests to at least run the sample language files through to ensure code gen doesn't blow up. (The actual output isn't validated yet but validating it doesn't crash is a step forward). * * Simplified library init * Updated doc comments on limitation of one init per process (ever) * Added safer dispose to OrcJit as finalizer is allowed to run on a type where the constructor never did In particular if the constructor is called but fails to complete due to an exception, the finalizer is still called! * Corrected name of *Add*LowerAtomic transform method (#168)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.