Skip to content

Commit

Permalink
Merge dashpay#6487: ci: exclude more files from artifacts, better nam…
Browse files Browse the repository at this point in the history
…es for downloaded files

a191c09 ci: better names for artifacts (UdjinM6)
3984a49 ci: exclude `*.a` and `*.o` files from artifacts (UdjinM6)

Pull request description:

  ## Issue being fixed or feature implemented
  We include too many files in artifacts on `build` ci step, some of which (`*.a` and `*.o`) can be pretty heavy. This was ok-ish for some time but artifacts size is getting closer to the limit and even starts to cause issues, see dashpay#6462.

  ## What was done?
  Exclude `*.a` and `*.o` files from artifacts. Also, change artifacts name to make it easier to distinguish them when you get a few of them from the same pipeline - `build-arm-linux.zip`, `build-linux64.zip` etc. instead of `binaries.zip`, `binaries (1).zip` etc., same for `depends`.

  A simpler alternative to dashpay#6483

  As a result the size of tsan artifacts for example is down from 508MB in 6462 to 154MB in this PR.

  ## How Has This Been Tested?

  ## Breaking Changes

  ## Checklist:
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  PastaPastaPasta:
    utACK a191c09
  kwvg:
    utACK a191c09

Tree-SHA512: eb3029c95a11546958d34ad284f4eb600b6113a2cabb885f7381afd16696f51da7eaf1677a1cdfec53311838c6845bb1c2c7c98f0ae112294b33f6ab6c66c500
  • Loading branch information
PastaPastaPasta committed Dec 14, 2024
2 parents 4a63d64 + a191c09 commit 99ca07f
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ builder-image:
- depends/built
- depends/sdk-sources
artifacts:
name: depends
name: depends-${CI_JOB_NAME}
when: on_success
paths:
- depends/$HOST
Expand Down Expand Up @@ -130,12 +130,14 @@ builder-image:
paths:
- cache/ccache
artifacts:
name: binaries
name: build-${BUILD_TARGET}
when: always
paths:
- build-ci
# Exclude some less important binaries to reduce the size of the artifacts
exclude:
- build-ci/dashcore-$BUILD_TARGET/src/**/*.a
- build-ci/dashcore-$BUILD_TARGET/src/**/*.o
- build-ci/dashcore-$BUILD_TARGET/src/bench/bench_dash
- build-ci/dashcore-$BUILD_TARGET/src/bench/bench_dash.exe
- build-ci/dashcore-$BUILD_TARGET/src/qt/test/test_dash-qt
Expand Down

0 comments on commit 99ca07f

Please sign in to comment.