fix(qt): allow refreshing wallet data without crashing

UdjinM6 · Dec 6, 2024 · ec55834 · ec55834
1 parent 65800cb
commit ec55834
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/src/qt/transactiontablemodel.cpp b/src/qt/transactiontablemodel.cpp
@@ -106,10 +106,11 @@ class TransactionTablePriv
 
     /* Query entire wallet anew from core.
      */
-    void refreshWallet(interfaces::Wallet& wallet)
+    void refreshWallet(interfaces::Wallet& wallet, bool force = false)
     {
         parent->beginResetModel();
-        assert(!m_loaded);
+        assert(!m_loaded || force);
+        cachedWallet.clear();
         try {
             for (const auto& wtx : wallet.getWalletTxs()) {
                 if (TransactionRecord::showTransaction()) {
@@ -121,7 +122,9 @@ class TransactionTablePriv
         }
         parent->endResetModel();
         m_loaded = true;
-        DispatchNotifications();
+        if (!force) {
+            DispatchNotifications();
+        }
     }
 
     /* Update our model of the wallet incrementally, to synchronize our model of the wallet
@@ -284,9 +287,9 @@ TransactionTableModel::~TransactionTableModel()
     delete priv;
 }
 
-void TransactionTableModel::refreshWallet()
+void TransactionTableModel::refreshWallet(bool force)
 {
-    priv->refreshWallet(walletModel->wallet());
+    priv->refreshWallet(walletModel->wallet(), force);
 }
 
 /** Updates the column title to "Amount (DisplayUnit)" and emits headerDataChanged() signal for table headers to react. */
@@ -848,7 +851,7 @@ void TransactionTablePriv::DispatchNotifications()
         }
     } else {
         // it's much faster to just refresh the whole thing instead
-        bool invoked = QMetaObject::invokeMethod(parent, "refreshWallet", Qt::QueuedConnection);
+        bool invoked = QMetaObject::invokeMethod(parent, "refreshWallet", Qt::QueuedConnection, Q_ARG(bool, true));
         assert(invoked);
     }
     vQueueNotifications.clear();

diff --git a/src/qt/transactiontablemodel.h b/src/qt/transactiontablemodel.h
@@ -114,7 +114,7 @@ class TransactionTableModel : public QAbstractTableModel
 
 public Q_SLOTS:
     /* Refresh the whole wallet, helpful for huge notification queues */
-    void refreshWallet();
+    void refreshWallet(bool foce = false);
     /* New transaction, or transaction changed status */
     void updateTransaction(const QString &hash, int status, bool showTransaction);
     void updateAddressBook(const QString &address, const QString &label,