Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken bookmarks are outputted if title contains non-ASCII characters. #789

Closed
filzrev opened this issue Mar 9, 2024 · 1 comment
Closed

Broken bookmarks are outputted if title contains non-ASCII characters. #789

filzrev opened this issue Mar 9, 2024 · 1 comment
Assignees
@BobLd
Labels
document-editing Related to creating or editing/modifying documents

Comments

@filzrev
Copy link

filzrev commented Mar 9, 2024

Describe the bug
When bookmark title contains some non-ASCII characters.
Bookmark is not outputted correctly.

To Reproduce
I've created unit tests that cause problems.

https://github.com/filzrev/PdfPig/blob/c2b9d43ef71f61ecac0bec0ef05d3767965d7912/src/UglyToad.PdfPig.Tests/Integration/NonAsciiCharactorsBookmarksTests.cs
@filzrev filzrev mentioned this issue Mar 9, 2024
Closed
BobLd added a commit to BobLd/PdfPig that referenced this issue Mar 10, 2024
@BobLd
Ensure string characters are escaped when encoding is Utf16BE and fix U…
4c51b48 
…glyToad#789
@BobLd
Copy link
Collaborator

BobLd commented Mar 10, 2024

@filzrev thanks very much for providing the tests, I've created a fix PR

@BobLd BobLd added the document-editing Related to creating or editing/modifying documents label Mar 10, 2024
@BobLd BobLd self-assigned this Mar 10, 2024
@BobLd BobLd closed this as completed in 250362e Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BobLd BobLd

Labels
document-editing Related to creating or editing/modifying documents
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BobLd @filzrev