Improve Code Quality #818
Merged
Improve Code Quality #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
iamcarbon
commented
Apr 12, 2024
•
iamcarbon
commented
- Make various small classes structs
- Pass various structs by readonly ref (in)
- Eliminate various substring allocations
- Eliminate various virtual calls
- Optimize ReadHelper methods
- Optimize NameTokenizer
|
@BobLd Ready for review / feedback. |
|
@iamcarbon can you include my PR changes from f7d1aee in this PR. I want to avoid having to fix conflicts later on |
BobLd
requested changes
Apr 14, 2024
Included! |
|
@BobLd All set. |
BobLd
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.