Skip to content

Commit

Permalink
Fix translations of log-in page and sync message
Browse files Browse the repository at this point in the history
The French and Italian translations didn't have proper newlines there.
The message for the sync progress wasn't translated because it didn't properly get the catalog.

Contributes to issue CURA-8472.
  • Loading branch information
Ghostkeeper committed Sep 7, 2021
1 parent 5678b19 commit 534e119
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
6 changes: 4 additions & 2 deletions plugins/Toolbox/src/CloudSync/DownloadPresenter.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

from PyQt5.QtNetwork import QNetworkReply

from UM import i18n_catalog
from UM.i18n import i18nCatalog
from UM.Logger import Logger
from UM.Message import Message
from UM.Signal import Signal
Expand All @@ -15,6 +15,8 @@
from cura.UltimakerCloud.UltimakerCloudScope import UltimakerCloudScope
from .SubscribedPackagesModel import SubscribedPackagesModel

i18n_catalog = i18nCatalog("cura")


class DownloadPresenter:
"""Downloads a set of packages from the Ultimaker Cloud Marketplace
Expand Down Expand Up @@ -90,7 +92,7 @@ def _createProgressMessage(self) -> Message:
lifetime = 0,
use_inactivity_timer = False,
progress = 0.0,
title = i18n_catalog.i18nc("@info:title", "Changes detected from your Ultimaker account", ))
title = i18n_catalog.i18nc("@info:title", "Changes detected from your Ultimaker account"))

def _onFinished(self, package_id: str, reply: QNetworkReply) -> None:
self._progress[package_id]["received"] = self._progress[package_id]["total"]
Expand Down
5 changes: 4 additions & 1 deletion resources/i18n/fr_FR/cura.po
Original file line number Diff line number Diff line change
Expand Up @@ -3127,7 +3127,10 @@ msgid ""
"- Add material profiles and plug-ins from the Marketplace\n"
"- Back-up and sync your material profiles and plug-ins\n"
"- Share ideas and get help from 48,000+ users in the Ultimaker community"
msgstr "- Ajoutez des profils de matériaux et des plug-ins à partir de la Marketplace - Sauvegardez et synchronisez vos profils de matériaux et vos plug-ins - Partagez vos idées et obtenez l'aide de plus de 48 000 utilisateurs de la communauté Ultimaker"
msgstr ""
"- Ajoutez des profils de matériaux et des plug-ins à partir de la Marketplace\n"
"- Sauvegardez et synchronisez vos profils de matériaux et vos plug-ins\n"
"- Partagez vos idées et obtenez l'aide de plus de 48 000 utilisateurs de la communauté Ultimaker"

#: /home/trin/Gedeeld/Projects/Cura/resources/qml/Account/GeneralOperations.qml:62
msgctxt "@button"
Expand Down
3 changes: 2 additions & 1 deletion resources/i18n/it_IT/cura.po
Original file line number Diff line number Diff line change
Expand Up @@ -3130,7 +3130,8 @@ msgid ""
"- Share ideas and get help from 48,000+ users in the Ultimaker community"
msgstr ""
"- Aggiungi profili materiale e plugin dal Marketplace\n"
"- Esegui il backup e la sincronizzazione dei profili materiale e dei plugin⏎- Condividi idee e ottieni supporto da più di 48.000 utenti nella community di Ultimaker"
"- Esegui il backup e la sincronizzazione dei profili materiale e dei plugin\n"
"- Condividi idee e ottieni supporto da più di 48.000 utenti nella community di Ultimaker"

#: /home/trin/Gedeeld/Projects/Cura/resources/qml/Account/GeneralOperations.qml:62
msgctxt "@button"
Expand Down

0 comments on commit 534e119

Please sign in to comment.