Cura 11561 mockup pap #18246
Cura 11561 mockup pap #18246
Conversation
This reverts commit 54af5bc.
| @@ -228,11 +234,14 @@ def preRead(self, file_name, show_dialog=True, *args, **kwargs): | |||
| self._resolve_strategies = {k: None for k in resolve_strategy_keys} | |||
| containers_found_dict = {k: False for k in resolve_strategy_keys} | |||
|
|
|||
| # Check whether the file is a UCP, which changes some import options | |||
| is_ucp = file_name.endswith('.ucp') | |||
There was a problem hiding this comment.
It's fine for now, but for the future i would just look for the extra settings file. That way it's already compatible if we ever decide to merge it.
There was a problem hiding this comment.
This would be cleaner indeed 👍
|
|
||
| @call_on_qt_thread | ||
| def write(self, stream, nodes, mode=WorkspaceWriter.OutputMode.BinaryMode): | ||
| def _preWrite(self): |
There was a problem hiding this comment.
Not the greatest solution, but it's fine for the mockup. When integrating this, i do think we should split off the preWrite.
There was a problem hiding this comment.
Also, why not also just give the pre_write an extra param if it's an UCP or not. You can use a lambda in the call later
There was a problem hiding this comment.
The reader classes have explicit preRead and read methods, so we should probably do the same for the writers. I didn't want to go there for the mockup, but for integration yes.
For the extra param, I don't really understand what you mean. What I think is that we should add a param to the write method which is the mimetype of the file to be written. Or allow the mode param (which is currently useful only for the STLs) to be any type, and then have a specific enum for the 3MF/UCP.
Implements a mockup for testing the Printer Agnostic Project new feature. This is really a preview and would probably require some technical+feature polishing to be fully usable.
Don't merge to main !
CURA-11561