Fix missing setting_version after translation #2450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #2117. A recent change implemented a check against the "setting_version" metadata when importing profiles. Legacy profiles translation does not add this entry, which leads to Cura failing to import the translated profile.
|
This is not the desired solution. You may say that the settings are at version 2, but they aren't. They need to be upgraded to version 2 first. The legacy profile importer imports the profiles to the format they were in at Cura 2.1, but settings have been deleted since then, and renamed, and have their units changed. This is the reason for checking against the setting version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2117.
0f5814e implemented a check against the "setting_version" metadata when importing profiles. Legacy profile translation does not add this entry, which leads to Cura failing to import the translated profile.