Version upgrade 4.5 to 4.6 for Maximum Deviation changes #7247
Conversation
Because Cura 4.6 fixes a bug in simplify, which means the max deviation setting is interpreted 4x as high Increments version number in profiles and fdmprinter.def.json ans fdmextruder.def.json and CuraApplication.py
Due to a bug the setting used to be interpreted half as high as they were. Now the bug is fixed and the values are interpreted as twice what they used to be. In order to keep the behavior the same, we therefore halve all the values of that setting
required to update values of meshfix_maximum_deviation such that the behavior is the same
|
This doesn't include any changes to the version "4.5" to "4.6". Should it? I don't think doing the whole version 4.6 should be part of this PR. |
|
Wow, 1400+ files need to change for such a small update. That puts startup performance into perspective... |
|
Haha yeah. I always have the biggest PRs :D |
|
It is sort of indicative though of a larger issue that the current approach of having all those quality profiles for all those printers in the main download is not tenable. Wasn't there once a plan to host them externally (Marketplace)? |
|
@fieldOfView there was, but it requires some refactoring regarding XML material profiles (they can contain printer-specific settings) so we never came around to it so far. |
Ghostkeeper
changed the title
|
This PR is superseded by #7385. |
Includes value changes for
meshfix_maximum_deviation, so that its behavior remains the same.Required for Ultimaker/CuraEngine#1214
Some profiles used to set the meshfix_maximum_deviation to an odd number of microns. I rounded them down after halving their values.