Code

New Tree Support Implementation#1282

Code

Merged

casperlamboo merged 120 commits intoUltimaker:mainUltimaker/CuraEngine:mainfrom ThomasRahm:tree_support_2ThomasRahm/CuraEngine:tree_support_2Copy head branch name to clipboardApr 25, 2023

+6,935-806

Commits

Commits on Jul 2, 2020

• Implemented new tree support

  ThomasRahm

  committed
  6b38494

• Changed filename of linearAlg2D.h import to lower case.

  ThomasRahm

  committed
  416b437

Commits on Jul 3, 2020

• Fixed support_tree_support_line_outset causing useless inital areas. Also fixed hole detection in projectInwardsFromOutline and a few missing new lines in log messages.

  ThomasRahm

  committed
  b37be4a

• Fixed crash when no support is needed.

  ThomasRahm

  committed
  c94ce44

Commits on Jul 6, 2020

• Removed a few setting including the legacy tree support and the demo.cfg

  ThomasRahm

  committed
  458b3fc

Commits on Jul 20, 2020

• Further removed settings. Top area is now support roof. Also fixed some bugs and started renaming.

  ThomasRahm

  committed
  f275bfd

Commits on Aug 13, 2020

• Smoothed branch movement and added that branches try to not move for the amount of support roof layers if support roof is enabled, but the overhang area is to small for a roof.

  ThomasRahm

  committed
  a58f515

Commits on Sep 1, 2020

• Reimplemented ModelVolumes to enable new features, added support for Distance Priority and improved to model adhesion

  ThomasRahm

  committed
  9ff9bc4

Commits on Sep 3, 2020

• Added support for correct handling of per mesh settings.

  ThomasRahm

  committed
  12ff206

• Reordered functions for better readability

  ThomasRahm

  committed
  7033244

• Fixed progress bar jumping around and improved performance if meshes with different mesh settings have a different height of the first overhang

  ThomasRahm

  committed
  4569cd1

Commits on Sep 17, 2020

• Multiple Bugfixes

  ThomasRahm

  committed
  69917f0

Commits on Sep 23, 2020

• small bugfix

  ThomasRahm

  committed
  9fbef7c

Commits on Nov 21, 2020

• Merge remote-tracking branch 'upstream/4.8' into tree_support_2

  ThomasRahm

  committed
  1056fa0

Commits on Feb 19, 2021

• A ton of bugfixes

  ThomasRahm

  committed
  9b000a9

Commits on May 1, 2021

• Merge tag '4.9.0' into tree_support_2: Updated to CuraEngine 4.9

  Show description for 34e396a
  ThomasRahm

  committed
  34e396a

• Applied automated formatting, added more comments, and improved code quality a bit

  ThomasRahm

  committed
  089da0b

Commits on May 3, 2021

• Fixed issues with non model meshes. Also fixed issues when avoidances or similar of layer 0 are requested.

  ThomasRahm

  committed
  f1a413d

Commits on Jul 19, 2021

• Merge branch '4.10' of https://github.com/Ultimaker/CuraEngine into tree_support_2

  ThomasRahm

  committed
  d5867df

• Fixed inital layer diameter causing not precalculated avoidance radiis to be requested

  ThomasRahm

  committed
  434d355

Commits on Aug 18, 2021

• Removed broken "Minimum Support Floor Area" setting from TreeSupport

  ThomasRahm

  committed
  1050573

Commits on Aug 21, 2021

• Small bug-fix regarding smoothing the tree after a branch went through a small hole.

  ThomasRahm

  committed
  abe4dbb

Commits on Nov 6, 2021

• Fixed support roof not being able to reach the buildplate when it should. Improved performance when a lot of roof areas are present.

  ThomasRahm

  committed
  8e4710d

Commits on Nov 12, 2021

• Refactored drawAreas and moved most of the code into one of four different fuctions.

  ThomasRahm

  committed
  724b687

Commits on Nov 13, 2021

• Updated to 4.12

  ThomasRahm

  committed
  c218041

Commits on Dec 3, 2021

• Fixed missing tips when minimum z distance is small, improved tip placement and improved performance in some cases.

  ThomasRahm

  committed
  8b32357

Commits on Dec 4, 2021

• Fixed tree support generating hanging in certain situations

  ThomasRahm

  committed
  d5aad83

Commits on Mar 17, 2022

• Added minimum tip radius and interface preference settings. Added tip becoming roof when tip larger than minimum roof area. Some bugfixes.

  ThomasRahm

  committed
  48200dc

Commits on Mar 21, 2022

• Update to 4.13

  ThomasRahm

  committed
  b5ac583

Commits on Mar 25, 2022

• Improved tip placement when tip radius is large

  ThomasRahm

  committed
  143714a

Commits on Apr 3, 2022

• Fixed branches generating not supporting overhang when z overrides xy distance

  ThomasRahm

  committed
  8a75061

Commits on Apr 6, 2022

• Fixed dropping down of non-gracious support areas

  ThomasRahm

  committed
  346128e

Commits on May 24, 2022

• Merge branch '5.0' of https://github.com/Ultimaker/CuraEngine into tree_support_2

  Show description for d4a5e83
  ThomasRahm

  committed
  d4a5e83

Commits on May 25, 2022

• Updated to 5.0. Fixed some potential bugs. Split ModelVolumes into its own files. Improved spelling and documentation.

  ThomasRahm

  committed
  07e92a3

Commits on May 30, 2022

• Changed order of parallel_for_nowait and parallel_for to fix compilation issues under linux

  ThomasRahm

  committed
  5d684ce

Commits on Aug 25, 2022

• Added Feature to limit reach of each branch and another to ignore prefering the buildplate over flat parts of the model. Also fixed a few bugs.

  ThomasRahm

  committed
  d7769a7

Commits on Sep 12, 2022

• Remove parallel for nowait before update to 5.1

  ThomasRahm

  committed
  4f8c494

• Merge tag '5.1.0' into tree_support_2

  ThomasRahm

  committed
  bdcdb3a

• Update to 5.1. Also a small potential bugfix and minor restructuring.

  ThomasRahm

  committed
  11742dd

Commits on Sep 20, 2022

• Fixed wrong placement of branches on buildplate when using rest on any surface preference

  ThomasRahm

  committed
  26ebae0

Commits on Oct 20, 2022

• Merge remote-tracking branch 'upstream/5.2' into tree_support_2

  Show description for ecd1ff1
  ThomasRahm

  committed
  ecd1ff1

• Update to Cura 5.2 and implement support_tree_max_diameter.

  ThomasRahm

  committed
  a5406e7

Commits on Oct 25, 2022

• Fixed issue preventing slicing of multiple models at the same time.

  ThomasRahm

  committed
  034fe14

Commits on Nov 3, 2022

• Merge remote-tracking branch 'upstream/main' into tree_support_2

  Show description for e535e04
  ThomasRahm

  committed
  e535e04

Commits on Nov 5, 2022

• Removed usage of outer_poly_first_layer

  ThomasRahm

  committed
  553a012

Commits on Nov 17, 2022

• Revert "Merge pull request Ultimaker#1738 from Piezoid/area_deviation_scaling"

  Show description for 70b4fbf
  rburema

  committed
  70b4fbf

Commits on Dec 13, 2022

• Merge branch '5.2' into xmas_alpha

  rburema

  committed
  381c257

• Revert "Merge remote-tracking branch 'upstream/main' into tree_support_2"

  Show description for fa11a4b
  rburema

  committed
  fa11a4b

Commits on Dec 14, 2022

• New Tree Support: Quick refactors (except the big class).

  Show description for a275e9d
  rburema

  committed
  a275e9d

Commits on Dec 15, 2022

• Sync workflows from main

  Show description for ccd74e0
  jellespijker

  committed
  ccd74e0

• Use 5.3.0-alpha dependencies

  Show description for 296d38d
  jellespijker

  committed
  296d38d

• Use latest Arcus

  Show description for 958bb86
  jellespijker

  committed
  958bb86

• Use PUBLIC targets for deps in _CuraEngine

  Show description for 80e50f2
  jellespijker

  committed
  80e50f2

• Use range-v3 instead of std

  Show description for 64e626d
  jellespijker

  committed
  64e626d

• New Tree Support: Refactors part II.

  Show description for 2772aa8
  rburema

  committed
  2772aa8

Commits on Dec 16, 2022

• Fix xy_distance overriding overhangs when the overhang angle is smallish

  ThomasRahm

  committed
  30d28cd

• New Tree Support: Refactors part III.

  Show description for 9e1eb70
  rburema

  committed
  9e1eb70

• Switch back to the original 'pass-by-copy' design.

  Show description for b734714
  rburema

  committed
  b734714

• Fix xy_distance overriding overhangs when the overhang angle is smallish.

  Show description for 8b9c8ac
  

  ThomasRahm

  authored and

  rburema

  committed
  8b9c8ac

• Small refactor: Break some more comments up into lines.

  Show description for cf52880
  rburema

  committed
  cf52880

• Small refactors (mostly re-lined comments).

  Show description for 2a25383
  rburema

  committed
  2a25383

• Forgot to rename this instance of mesh for the apple-clang workaround.

  Show description for ace3dba
  rburema

  committed
  ace3dba

• Refactor: Use 'using' to abreviate often used types.

  Show description for 92e39af
  rburema

  committed
  92e39af

• Minimize use of (implict) sqrt operations.

  Show description for 8ce602f
  rburema

  committed
  8ce602f

• Replaced some of the more common magic numbers with constexprs.

  Show description for 7427d77
  rburema

  committed
  7427d77

• Resolve temporary comments made during review.

  Show description for 885fe03
  rburema

  committed
  885fe03

Commits on Dec 20, 2022

• 'Workaround' for crash with tree-branch-pref set to 'flat surfaces'.

  Show description for a0dd35d
  rburema

  committed
  a0dd35d

Commits on Dec 22, 2022

• Fix for inital layer diameter not working when rest preference is on any flat surface

  ThomasRahm

  committed
  e81807b

• Undo small part of refactor that was causing issues.

  Show description for 3c41803
  rburema

  committed
  3c41803

Commits on Dec 27, 2022

• Fix mistakenly always requesting regular avoidance and fix slicing not terminating sometimes when limit branch reach is active

  ThomasRahm

  committed
  201a12d

• Fix potential issue causing to buildplate branches merging with to model branches to have sudden differences in radius

  ThomasRahm

  committed
  4d65ae7

Commits on Jan 3, 2023

• Merge remote-tracking branch 'upstream/CURA-9879_a_tree_by_xmas' into tree_support_2_refactored

  Show description for 6649125
  ThomasRahm

  committed
  6649125

• Fix bug in getNextPointWithDistance and fix bug when subtracting lines from areas when handling interface preference

  ThomasRahm

  committed
  1724f67

• Added comment explaining why a refactor has caused unintentional issues in the past

  ThomasRahm

  committed
  6217ebf

Commits on Jan 4, 2023

• Possible fix for "Floating islands inside of support"

  ThomasRahm

  committed
  8bd759a

Commits on Jan 24, 2023

• Fix potential edge case: All but one of empty list.

  rburema

  committed
  99ca0f9

• take disallowed areas into account when printing tree support

  

  BagelOrb

  authored and

  rburema

  committed
  a0d1e3a

• feat: settings.get<Polygons>

  

  BagelOrb

  authored and

  rburema

  committed
  d51bfc0

• Moved PropertyAreasX definitions to where they're used.

  rburema

  committed
  369c74d

Commits on Jan 25, 2023

• Merge remote-tracking branch 'upstream/CURA-9879_a_tree_by_xmas' into tree_support_2_refactored

  ThomasRahm

  committed
  9675cde

Commits on Feb 2, 2023

• Fix regression causing some tips to not generate

  ThomasRahm

  committed
  f3975c3

Commits on Feb 27, 2023

• Ensure trees never rest on support blocker

  ThomasRahm

  committed
  1d62038

Commits on Mar 6, 2023

• Fix unexpected behaviour of tip generation when support distance priority is xy overrides z

  ThomasRahm

  committed
  2e5515d

• Fix branches that are larger than their collision radius getting unnecessarily close to the model, causing the branch to deform

  ThomasRahm

  committed
  f3c1eb2

Commits on Mar 7, 2023

• Fix bug caused by previous commit

  ThomasRahm

  committed
  139afd1

Commits on Mar 10, 2023

• Revert "Revert "Merge remote-tracking branch 'upstream/main' into tree_support_2""

  Show description for 5a25ed2
  ThomasRahm

  committed
  5a25ed2

• Revert "Revert "Merge pull request Ultimaker#1738 from Piezoid/area_deviation_scaling""

  Show description for 9ac75a4
  ThomasRahm

  committed
  9ac75a4

• Merge remote-tracking branch 'upstream/main' into tree_support_2

  Show description for c8838e6
  ThomasRahm

  committed
  c8838e6

Commits on Mar 15, 2023

• Reworked support roof generatrion for tree supports

  ThomasRahm

  committed
  36a4c42

Commits on Mar 16, 2023

• Fix bug introduced with previous commit, causing support roof that was replaced with support to be not supported by trees

  ThomasRahm

  committed
  bd1516a

Commits on Mar 21, 2023

• Merge branch 'main' into CURA-10415_update_tree

  rburema

  committed
  2cde161

• Merge branch 'main' into CURA-10415_update_tree

  rburema

  committed
  bde1bea

• Fix merge main into tree-support 2.0 branch.

  Show description for aee2cd0
  rburema

  committed
  aee2cd0

Commits on Mar 22, 2023

• Error handling for a small rounding error that may cause small roof areas to be not supported. Also some small tweaks that maybe could prevent the same issue.

  ThomasRahm

  committed
  f39362d

• Merge remote-tracking branch 'trahm/tree_support_2' into CURA-10415_update_tree

  rburema

  committed
  ddbcdd1

• Fix divide by zero errors when xy-dist = 0.

  Show description for 1a681df
  rburema

  committed
  1a681df

• Fix roof being not supported by trees

  ThomasRahm

  committed
  ad06a7a

• Small improvement of previous fix

  ThomasRahm

  committed
  f2d4835

• Merge remote-tracking branch 'trahm/tree_support_2' into CURA-10415_update_tree

  rburema

  committed
  d63fb22

Commits on Mar 28, 2023

• Fix one layer tall trees being removed

  ThomasRahm

  committed
  854fe71

Commits on Mar 29, 2023

• Fixed tip placement issue, causing not supported roof lines

  ThomasRahm

  committed
  d046eaf

Commits on Mar 30, 2023

• Fix missing support for one roof line

  ThomasRahm

  committed
  f20f751

Commits on Mar 31, 2023

• Merge remote-tracking branch 'trahm/tree_support_2' into CURA-10415_update_tree

  rburema

  committed
  6706feb

Commits on Apr 5, 2023

• Merge branch 'main' into CURA-10415_update_tree

  Show description for d8e6992
  casperlamboo

  committed
  d8e6992

• Speed-up (+fix) for 'safeOffset' function.

  Show description for cabefc6
  rburema

  committed
  cabefc6

• Speedup of SafeOffsetInc function.

  Show description for 0670225
  rburema

  committed
  0670225

• Decrease verices per 'circle' (TreeSupport 2.0)

  Show description for 63109db
  rburema

  committed
  63109db

• Unioning many (often small) circles took too long. Fix that.

  Show description for 56d3fe6
  rburema

  committed
  56d3fe6

Commits on Apr 6, 2023

• Modernize: Partition via ranges.

  Show description for fd177af
  

  rburema

  and

  casperlamboo

  authored
  fd177af

• Put back as for-loop, but reserve sizes beforehand.

  Show description for fd0dfbc
  rburema

  committed
  fd0dfbc

• Merge branch 'CURA-10415_update_tree' into CURA-10464_speedy_tree

  rburema

  authored
  19de6e8

• Merge pull request Ultimaker#1873 from Ultimaker/CURA-10464_speedy_tree

  Show description for ae7f0e2
  rburema

  authored
  ae7f0e2

• Merge branch 'main' into CURA-10415_update_tree

  jellespijker

  committed
  a7ef632

• Add scripta log statement for exclude polys

  Show description for 81b0ee5
  jellespijker

  committed
  81b0ee5

Commits on Apr 7, 2023

• Someone accidentally ctrl-v'd this in here. Remove.

  rburema

  committed
  58b8a80

• Log tree_support_layer_storage

  Show description for f9ce71f
  jellespijker

  committed
  f9ce71f

Commits on Apr 13, 2023

• Experimental hole removal for tree support

  ThomasRahm

  committed
  d340e68

Commits on Apr 15, 2023

• Improved performance of hole removal (to prevent floating lines inside branches). This includes porting a function from PrusaSlicer that intersects a Polygon with an AABB. Fixed a small bug related…

  Show description for e676aab
  ThomasRahm

  committed
  e676aab

Commits on Apr 16, 2023

• Reworked and improved tree support tip handling for large areas when interface is disabled.

  ThomasRahm

  committed
  c3bc966

Commits on Apr 19, 2023

• Improved support of high density roof structures by placing tips to form a lower density structure below it instead of placing tips directly below the rooflines (which could cause tip-areas to merg…

  Show description for bb5380a
  ThomasRahm

  committed
  bb5380a