Don't remove surface mode both cutting mesh areas. #1608
Merged
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BagelOrb
force-pushed
the
fix_surface_mode_both_cutting_mesh
branch
from
aa0a23c to
572f10a
Compare
|
I don't remember which bug this solves exactly, but judging from the code it should solve a bug where surface mode both would not generate any surface geometry in case of cutting meshes. However, I'm not able to reproduce the bug in 5.1.0 |
The polylines are recomputed by the stitching, so they should be cleared. However, the polygons should not be cleared for surface mode BOTH. They are already cleared for surface mode SURFACE, 35 lines above at line 150. Fixes CURA-9037
BagelOrb
force-pushed
the
fix_surface_mode_both_cutting_mesh
branch
from
572f10a to
4a389e9
Compare
|
Reproduced bug in main: With the fix: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The polylines are recomputed by the stitching, so they should be cleared.
However, the polygons should not be cleared for surface mode BOTH.
They are already cleared for surface mode SURFACE, 35 lines above at line 150.