Skip to content

Commit

Permalink
Merge pull request #969 from Ultimaker/CURA-6842_crash_when_renmaing_…
Browse files Browse the repository at this point in the history
…profiles

Add supress_signals property to setName of instance container
  • Loading branch information
HellAholic authored Sep 30, 2024
2 parents da1c5e8 + 1426cab commit 30d1f94
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions UM/Settings/InstanceContainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -214,14 +214,18 @@ def getName(self) -> str:

return self._metadata["name"]

def setName(self, name: str) -> None:
def setName(self, name: str, *, supress_signals = False) -> None:
# In some cases you want to change the name of multiple containers and not yet want to trigger events.
# In thsoe cases you need to use supress_signals to make sure that no signals are sent. Be *very* carefull
# with using this!
if name != self.getName():
CachedMemberFunctions.clearInstanceCache(self)
self._metadata["name"] = name
self._dirty = True
self.nameChanged.emit()
self.pyqtNameChanged.emit()
self.metaDataChanged.emit(self)
if not supress_signals:
self.nameChanged.emit()
self.pyqtNameChanged.emit()
self.metaDataChanged.emit(self)


# Because we want to expose the properties of InstanceContainer as Qt properties for
Expand Down

0 comments on commit 30d1f94

Please sign in to comment.