Frontend plugin orchestration #886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boyscouting. CURA-10717
Boyscouting CURA-10717
Boyscouting CURA-10717
Boyscouting CURA-10717
Boyscouting CURA-10717
…ltimaker/Uranium into CURA-10717_Engine_plugin_orchestration
Boyscouting CURA-10717
CURA-10717
Boyscouting CURA-10717
And more boyscouting. Damn this is some code that hasn't been touched in a while... CURA-10717
Boyscouting CURA-10717
CURA-10717
CURA-10717
Pretty rudimentary stuff, but one needs plumbing before moving on CURA-10717
I was running into abstraction issues when it was defined in Uranium. Instead of trying to fight those, it's just easier to move it to Cura CURA-10717
jellespijker
approved these changes
Jul 11, 2023
As per suggestions of review CURA-10717 Co-authored-by: Jelle Spijker <spijker.jelle@gmail.com>
Apply suggestions from code review CURA-10717 Co-authored-by: Jelle Spijker <spijker.jelle@gmail.com>
|
closing this PR since it was simple a rename to CURA-10475_engineplugin such that we have a consistent working branch name across all repo's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First rough draft of how the frontend will handle the backend_plugins.
Originally i added the concept of backend_plugins to uranium, but the extra abstraction made it clumsy quite fast. So i moved all of it over to Cura. The accompanying Uranium PR now essentially only contains boyscouting changes. Since they are still good to do, i've left them in.
Ultimaker/Cura#16110
CURA-10717