Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CS-2323
_aliases
: Do not replace non-top-level directories #34CS-2323
_aliases
: Do not replace non-top-level directories #34Changes from 3 commits
020d785
140f2bd
774dec4
204aa63
c6c08c8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checked this. Order of
rf
doesn't seem to matter.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought; now that I have taken a closer look at the code, this is a nice fail-safe but isn't this 'just' a case of an incorrect alias definition?
If you look at libCharon/Charon/filetypes/UltimakerFormatPackage.py, you see that all aliases are neatly prefixed with "^/"...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed in UltimakerFormatPackage there is a
^/
fixed. Thereexpression = rf"^{regex}"
doesn't fit here...On the other hand for replacement of paths, usually
/
refers to a top-level directory. It seems possible that when using it, even developers may forget putting^
at the beginning (and consider the method as merely a regex replacement, not a path handler).Therefore I'll just keep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My first suggestion still stands ;)