Cura 8640 PyQt6 upgrade #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to CURA-8640
These shouldn't be the responsibility of the consumer Contributes to CURA-8640
Contributes to CURA-8640
Contributes to CURA-8640
Otherwise the find package module can't be found Contributes to CURA-8640
This reverts commit d96dba3.
More control Contributes to CURA-8640
…RA-8640_PyQt6_upgrade
Contributes to CURA-8640
Contributes to CURA-8640
This was referenced Apr 12, 2022
Ghostkeeper
approved these changes
Apr 14, 2022
|
@Ghostkeeper no need to re-review, there are no changes since your last review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get this to work on our build-system and working for all three OSes we did a shit tons of boy scouting in our cmake. We removed old methods with variables and try to be consisted in a target-based approach. The idea is that we don't patch stuff down the line, but that the install should place everything with desired rpaths for each project.
Most of the changes had to do with how dependency targets were named and to make sure that external projects weren't downloaded automatically.
Part of
Fixes
Todo