Cura 7924 sip cmake build #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is ported from libArcus Modernized the find libnest2d allowing the usage of targets Contributes to CURA-7924
Contributes to CURA-7924
Contributes to CURA-7924 Co-authored-by: rburema <r.burema@ultimaker.com>
Co-authored-by: rburema <r.burema@ultimaker.com>
NLopt isn't used by pynest2d. It's a dependency of libnest2d Contributes to CURA-7924
Contributes to CURA-7924
Contributes to CURA-7924
Contributes to CURA-7924
This was referenced Feb 28, 2022
Contributes to CURA-7924
nallath
requested changes
Feb 28, 2022
| message(STATUS "Setting Python version to ${Python_VERSION}. Set Python_VERSION if you want to compile against an other version.") | ||
| endif() | ||
| if(APPLE) | ||
| set(Python_FIND_FRAMEWORK NEVER) |
There was a problem hiding this comment.
Suggested change
| set(Python_FIND_FRAMEWORK NEVER) | |
| set(Python_FIND_FRAMEWORK NEVER) |
ALready mentioned this for the libSavitar changes. We seem to have a good reason to do this, but it could also well be that we're just copying it from other files since "that how we have been doing it in the past". A bit of documentation to clarify why we do this would be good.
| super().__init__(project, **kwargs) | ||
|
|
||
| def build(self): | ||
| """ Only Generate the source files """ |
There was a problem hiding this comment.
Also same remark as the libsavitar one. You can probably copy the documentation from there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of: