Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve logging of portaudio + sdl audio latency #575

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adroste
Copy link

@adroste adroste commented Apr 14, 2021

Log latency infos for portaudio input/output and sdl output

Related to #576 and #573

@barbeque-squared
Copy link
Member

The additional/modified logging itself is fine, but when I try to git apply it locally I get a bunch of warnings about trailing whitespace:

[bbq@luna USDX]$ git apply 575.patch
575.patch:38: trailing whitespace.
    Log.LogStatus('Latency of ' + deviceInfo^.name + ': ' + 
575.patch:39: trailing whitespace.
                  floatToStr(StreamInfo^.inputLatency * 1000) + 
575.patch:40: trailing whitespace.
                  'ms (requested: ' + 
575.patch:41: trailing whitespace.
                  floatToStr(inputParams.suggestedLatency * 1000) + 
575.patch:55: trailing whitespace.
  Log.LogStatus('Audio-Output Latency: ' + floatToStr(Latency * 1000) + 
warning: squelched 3 whitespace errors
warning: 8 lines add whitespace errors.

I'm not sure if the warnings are a git thing or it picks up some editor thing somewhere, but either way the end of line whitespace is a bad idea. Could you remove those?
Ideally also rebase it against a current master, the CI has undergone quite some changes since this PR was opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants