Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scroll enabled on some dialog #119

Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix: scroll enabled on some dialog #119

merged 1 commit into from
Apr 25, 2022

Conversation

Senna46
Copy link
Collaborator

@Senna46 Senna46 commented Apr 25, 2022

This issue was mentioned UnUniFi/lab-test#37

Changes

  • Solved the problem of not displaying all forms when there is only a small display area.
    Scrolling can display it.
    • delagate-menu
    • delegate-form
    • redelegate-form
    • undelegate-form
    • deposit-form
    • vote-form

example
スクリーンショット 2022-04-25 160333

@Senna46 Senna46 changed the title fix: dialog scroll fix: dialog scroll enabled Apr 25, 2022
@Senna46 Senna46 changed the title fix: dialog scroll enabled fix: scroll enabled on some dialog Apr 25, 2022
YasunoriMATSUOKA
YasunoriMATSUOKA approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@YasunoriMATSUOKA YasunoriMATSUOKA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Senna46 Senna46 mentioned this pull request Apr 25, 2022
Merged
@Senna46 Senna46 merged commit dae6cf7 into main Apr 25, 2022
@YasunoriMATSUOKA YasunoriMATSUOKA added the bug Something isn't working label Apr 26, 2022
@YasunoriMATSUOKA YasunoriMATSUOKA deleted the hotfix/form-dialog-scroll-enable branch April 27, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YasunoriMATSUOKA YasunoriMATSUOKA YasunoriMATSUOKA approved these changes

@mkXultra mkXultra Awaiting requested review from mkXultra

Assignees

@Senna46 Senna46

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Senna46 @YasunoriMATSUOKA